You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/20 03:24:36 UTC

[GitHub] [flink] wsry opened a new pull request #16904: [FLINK-23724][network] Fix the network buffer leak when ResultPartition is released (cherry-pick)

wsry opened a new pull request #16904:
URL: https://github.com/apache/flink/pull/16904


   ## What is the purpose of the change
   
   This patch fixes the network buffer leak when ResultPartition is released by closing all BufferBuilders.
   
   ## Brief change log
   
     - All BufferBuilders are closed in the BufferWritingResultPartition#close method;
     - The TaskCanceler call the ResultPartition#fail method instead of the ResultPartition#close method because the close method can incur concurrency issue.
   
   
   ## Verifying this change
   
   An existing test is modified to cover the scenario.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16904: [FLINK-23724][network] Fix the network buffer leak when ResultPartition is released (cherry-pick)

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16904:
URL: https://github.com/apache/flink/pull/16904#issuecomment-902413906


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a12b477748275355e13f56c9daa866959b7ed7b8",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a12b477748275355e13f56c9daa866959b7ed7b8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a12b477748275355e13f56c9daa866959b7ed7b8 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16904: [FLINK-23724][network] Fix the network buffer leak when ResultPartition is released (cherry-pick)

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16904:
URL: https://github.com/apache/flink/pull/16904#issuecomment-902413906


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a12b477748275355e13f56c9daa866959b7ed7b8",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22527",
       "triggerID" : "a12b477748275355e13f56c9daa866959b7ed7b8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a12b477748275355e13f56c9daa866959b7ed7b8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22527) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16904: [FLINK-23724][network] Fix the network buffer leak when ResultPartition is released (cherry-pick)

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16904:
URL: https://github.com/apache/flink/pull/16904#issuecomment-902405412


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit a12b477748275355e13f56c9daa866959b7ed7b8 (Fri Aug 20 03:35:01 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16904: [FLINK-23724][network] Fix the network buffer leak when ResultPartition is released (cherry-pick)

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16904:
URL: https://github.com/apache/flink/pull/16904#issuecomment-902413906


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a12b477748275355e13f56c9daa866959b7ed7b8",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22527",
       "triggerID" : "a12b477748275355e13f56c9daa866959b7ed7b8",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a12b477748275355e13f56c9daa866959b7ed7b8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22527) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] curcur merged pull request #16904: [FLINK-23724][network] Fix the network buffer leak when ResultPartition is released (cherry-pick)

Posted by GitBox <gi...@apache.org>.
curcur merged pull request #16904:
URL: https://github.com/apache/flink/pull/16904


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org