You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/05/26 16:36:35 UTC

Review Request 47899: GEODE-1452: Annotate disabled test methods with @Ignore and @Test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47899/
-----------------------------------------------------------

Review request for geode, Jens Deppe, Jinmei Liao, Kevin Duling, and Dan Smith.


Bugs: GEODE-1452
    https://issues.apache.org/jira/browse/GEODE-1452


Repository: geode


Description
-------

GEODE-1452: Annotate disabled test methods with @Ignore and @Test

* remove some invalid tests
* remove some empty javadocs
* remove some dead code


Diffs
-----

  extensions/geode-modules-hibernate/src/test/java/com/gemstone/gemfire/modules/HibernateJUnitTest.java 9a86f10 
  extensions/geode-modules-hibernate/src/test/java/com/gemstone/gemfire/modules/SecondVMTest.java e3b6480 
  geode-core/src/test/java/com/gemstone/gemfire/cache/mapInterface/ExceptionHandlingJUnitTest.java fc3c35c 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/QueryServiceJUnitTest.java 0c34de7 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/CustomerOptimizationsJUnitTest.java 26e3aff 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/INOperatorJUnitTest.java fbc887c 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/IUMRCompositeIteratorJUnitTest.java 7c627c1 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/LimitClauseJUnitTest.java 5280dfb 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/MiscJUnitTest.java 4bd3258 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/MultiRegionIndexUsageJUnitTest.java 4b6071c 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/NestedQueryJUnitTest.java 11dcb0e 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/ResultsDataSerializabilityJUnitTest.java cb45bad 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/CompiledJunctionInternalsJUnitTest.java c3e1a45 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/QCompilerJUnitTest.java bcf0b65 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/IndexMaintainceJUnitTest.java 3ee758b 
  geode-core/src/test/java/com/gemstone/gemfire/cache/query/transaction/QueryAndJtaJUnitTest.java 162ffb1 
  geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java 827091f 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java 4eea76d 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/LIFOEvictionAlgoEnabledRegionJUnitTest.java 9df2468 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java d1be04d 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/BlockingHARegionJUnitTest.java 4b36b79 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/BlockingHARegionQueueJUnitTest.java ffb4771 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARQAddOperationJUnitTest.java 1c7b0d0 
  geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueJUnitTest.java b7fae40 

Diff: https://reviews.apache.org/r/47899/diff/


Testing
-------

precheckin (100% green)


Thanks,

Kirk Lund


Re: Review Request 47899: GEODE-1452: Annotate disabled test methods with @Ignore and @Test

Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47899/#review135802
-----------------------------------------------------------


Ship it!




Ship It!

- Jens Deppe


On May 26, 2016, 4:36 p.m., Kirk Lund wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47899/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 4:36 p.m.)
> 
> 
> Review request for geode, Jens Deppe, Jinmei Liao, Kevin Duling, and Dan Smith.
> 
> 
> Bugs: GEODE-1452
>     https://issues.apache.org/jira/browse/GEODE-1452
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1452: Annotate disabled test methods with @Ignore and @Test
> 
> * remove some invalid tests
> * remove some empty javadocs
> * remove some dead code
> 
> 
> Diffs
> -----
> 
>   extensions/geode-modules-hibernate/src/test/java/com/gemstone/gemfire/modules/HibernateJUnitTest.java 9a86f10 
>   extensions/geode-modules-hibernate/src/test/java/com/gemstone/gemfire/modules/SecondVMTest.java e3b6480 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/mapInterface/ExceptionHandlingJUnitTest.java fc3c35c 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/QueryServiceJUnitTest.java 0c34de7 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/CustomerOptimizationsJUnitTest.java 26e3aff 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/INOperatorJUnitTest.java fbc887c 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/IUMRCompositeIteratorJUnitTest.java 7c627c1 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/LimitClauseJUnitTest.java 5280dfb 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/MiscJUnitTest.java 4bd3258 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/MultiRegionIndexUsageJUnitTest.java 4b6071c 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/NestedQueryJUnitTest.java 11dcb0e 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/functional/ResultsDataSerializabilityJUnitTest.java cb45bad 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/CompiledJunctionInternalsJUnitTest.java c3e1a45 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/QCompilerJUnitTest.java bcf0b65 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/IndexMaintainceJUnitTest.java 3ee758b 
>   geode-core/src/test/java/com/gemstone/gemfire/cache/query/transaction/QueryAndJtaJUnitTest.java 162ffb1 
>   geode-core/src/test/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystemJUnitTest.java 827091f 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/Bug34179TooManyFilesOpenJUnitTest.java 4eea76d 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/LIFOEvictionAlgoEnabledRegionJUnitTest.java 9df2468 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java d1be04d 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/BlockingHARegionJUnitTest.java 4b36b79 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/BlockingHARegionQueueJUnitTest.java ffb4771 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARQAddOperationJUnitTest.java 1c7b0d0 
>   geode-core/src/test/java/com/gemstone/gemfire/internal/cache/ha/HARegionQueueJUnitTest.java b7fae40 
> 
> Diff: https://reviews.apache.org/r/47899/diff/
> 
> 
> Testing
> -------
> 
> precheckin (100% green)
> 
> 
> Thanks,
> 
> Kirk Lund
> 
>