You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2025/08/15 17:58:51 UTC

[PR] Remove outdated TODO in TableOperations.putSplits [accumulo]

DomGarguilo opened a new pull request, #5802:
URL: https://github.com/apache/accumulo/pull/5802

   Fixes #5791
   
   From what I can tell the feature mentioned in the TODO comment (updating existing splits) can be removed because:
   * putSplits() properly collects and handles existing splits that need TabletMergeability updates
   https://github.com/apache/accumulo/blob/a893ee5c5327748e101369850b983248cabf6153/core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java#L524
   * `updateSplitWithMergeabilityTest()` seems to properly cover this case
   * there are also tests covering concurrently updating overlapping splits properly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Remove outdated TODO in TableOperations.putSplits [accumulo]

Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo merged PR #5802:
URL: https://github.com/apache/accumulo/pull/5802


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org