You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/01 21:35:02 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6092: NIFI-10075 Improve TestListSFTP configuration verification

exceptionfactory opened a new pull request, #6092:
URL: https://github.com/apache/nifi/pull/6092

   # Summary
   
   [NIFI-10075](https://issues.apache.org/jira/browse/NIFI-10075) Improves the behavior of `TestListSFTP` to reduce the possibility of intermittent failures. The `assertVerificationSuccess()` method previously ran before each test method, attempting to verify server connectivity multiple times. Changing the private method to a regular test method checks runs the check once, minimizing potential issues and allowing the `startServer` method to complete before running. Additional changes include upgrading the test to JUnit 5 and removing unnecessary exception declarations.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
     - [ ] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #6092: NIFI-10075 Improve TestListSFTP configuration verification

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6092: NIFI-10075 Improve TestListSFTP configuration verification
URL: https://github.com/apache/nifi/pull/6092


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org