You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/21 15:00:17 UTC
[GitHub] [spark] wankunde opened a new pull request, #37602: [SPARK-40164][SQL] The partitionSpec should be distinct keys after filter one row of row_number
wankunde opened a new pull request, #37602:
URL: https://github.com/apache/spark/pull/37602
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Improve `DistinctKeyVisitor` that filter only one row for row_number output, the partitionSpec keys should be distinct.
For example:
```sql
SELECT *
FROM (
SELECT *, row_number() over(partition by key order by value) rn
FROM testData t
) t1
WHERE rn=1
```
column `key` will be distinct.
### Why are the changes needed?
Rule RemoveRedundantAggregates can remove unnecessary aggregate after this PR.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Add UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37602: [SPARK-40164][SQL] The partitionSpec should be distinct keys after filter one row of row_number
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37602: [SPARK-40164][SQL] The partitionSpec should be distinct keys after filter one row of row_number
URL: https://github.com/apache/spark/pull/37602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37602: [SPARK-40164][SQL] The partitionSpec should be distinct keys after filter one row of row_number
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37602:
URL: https://github.com/apache/spark/pull/37602#issuecomment-1332933187
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37602: [SPARK-40164][SQL] The partitionSpec should be distinct keys after filter one row of row_number
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37602:
URL: https://github.com/apache/spark/pull/37602#issuecomment-1221616015
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org