You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2018/09/04 09:37:20 UTC

[1/2] [lang] LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate

Repository: commons-lang
Updated Branches:
  refs/heads/master 3ee9cc840 -> 3e44d2634


LANG-1417: Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/54f8d3c0
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/54f8d3c0
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/54f8d3c0

Branch: refs/heads/master
Commit: 54f8d3c02abe04765ffe957e7d412bde2adf58c1
Parents: 3ee9cc8
Author: Benedikt Ritter <br...@apache.org>
Authored: Tue Sep 4 11:16:55 2018 +0200
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue Sep 4 11:16:55 2018 +0200

----------------------------------------------------------------------
 src/changes/changes.xml                                 |  1 +
 src/main/java/org/apache/commons/lang3/ThreadUtils.java | 10 ++++++----
 2 files changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-lang/blob/54f8d3c0/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 905c41f..705ccd0 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -46,6 +46,7 @@ The <action> type attribute can be add,update,fix,remove.
   <body>
 
   <release version="3.9" date="????-??-??" description="??">
+    <action issue="LANG-1417" type="update" dev="britter">Add @FunctionalInterface to ThreadPredicate and ThreadGroupPredicate</action>
     <action issue="LANG-1415" type="update" dev="britter">Update Java Language requirement to 1.8</action>
     <action issue="LANG-1411" type="add" dev="britter" due-to="Alexander Tsvetkov">Add isEmpty method to ObjectUtils</action>
   </release>

http://git-wip-us.apache.org/repos/asf/commons-lang/blob/54f8d3c0/src/main/java/org/apache/commons/lang3/ThreadUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/ThreadUtils.java b/src/main/java/org/apache/commons/lang3/ThreadUtils.java
index 1734b57..caf6fa0 100644
--- a/src/main/java/org/apache/commons/lang3/ThreadUtils.java
+++ b/src/main/java/org/apache/commons/lang3/ThreadUtils.java
@@ -239,8 +239,9 @@ public class ThreadUtils {
     /**
      * A predicate for selecting threads.
      */
-    //if java minimal version for lang becomes 1.8 extend this interface from java.util.function.Predicate
-    public interface ThreadPredicate /*extends java.util.function.Predicate<Thread>*/{
+    // When breaking BC, replace this with Predicate<Thread>
+    @FunctionalInterface
+    public interface ThreadPredicate {
 
         /**
          * Evaluates this predicate on the given thread.
@@ -253,8 +254,9 @@ public class ThreadUtils {
     /**
      * A predicate for selecting threadgroups.
      */
-    //if java minimal version for lang becomes 1.8 extend this interface from java.util.function.Predicate
-    public interface ThreadGroupPredicate /*extends java.util.function.Predicate<ThreadGroup>*/{
+    // When breaking BC, replace this with Predicate<ThreadGroup>
+    @FunctionalInterface
+    public interface ThreadGroupPredicate {
 
         /**
          * Evaluates this predicate on the given threadgroup.


[2/2] [lang] Merge branch 'LANG-1417'

Posted by br...@apache.org.
Merge branch 'LANG-1417'


Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/3e44d263
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/3e44d263
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/3e44d263

Branch: refs/heads/master
Commit: 3e44d26342654c8b2d8caba924ff468dd0e6e700
Parents: 3ee9cc8 54f8d3c
Author: Benedikt Ritter <br...@apache.org>
Authored: Tue Sep 4 11:37:00 2018 +0200
Committer: Benedikt Ritter <br...@apache.org>
Committed: Tue Sep 4 11:37:00 2018 +0200

----------------------------------------------------------------------
 src/changes/changes.xml                                 |  1 +
 src/main/java/org/apache/commons/lang3/ThreadUtils.java | 10 ++++++----
 2 files changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------