[GitHub] [iceberg] holdenk commented on a change in pull request #2257: Handle metrics during schema transformation

[GitBox <gi...@apache.org>]

holdenk commented on a change in pull request #2257:
URL: https://github.com/apache/iceberg/pull/2257#discussion_r626103929



##########
File path: core/src/main/java/org/apache/iceberg/MetricsConfig.java
##########
@@ -46,6 +47,35 @@ public static MetricsConfig getDefault() {
     return spec;
   }
 
+  public static Map<String, String> updateProperties(Map<String, String> props, List<String> deletes,

Review comment:
       I think this needs to be public since it's called from another class no?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org