You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/06/03 06:37:00 UTC
[jira] [Updated] (CALCITE-3099) The description of
SplunkPushDownRule doesn't match expression check in RelOptRule
[ https://issues.apache.org/jira/browse/CALCITE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated CALCITE-3099:
------------------------------------
Labels: pull-request-available (was: )
> The description of SplunkPushDownRule doesn't match expression check in RelOptRule
> ----------------------------------------------------------------------------------
>
> Key: CALCITE-3099
> URL: https://issues.apache.org/jira/browse/CALCITE-3099
> Project: Calcite
> Issue Type: Bug
> Components: splunk
> Affects Versions: 1.19.0
> Reporter: Shawn Chen
> Assignee: Shawn Chen
> Priority: Major
> Labels: pull-request-available
>
> Some SplunkPushDownRule instance has a description that contains spaces, for example:
> The description of _*PROJECT_ON_FILTER*_ is "proj on filter on proj", which doesn't match the expression check in RelOptRule:
> {code:java}
> if (!description.matches("[A-Za-z][-A-Za-z0-9_.():]*")) {
> throw new RuntimeException("Rule description '" + description
> + "' is not valid");
> }
> {code}
> The constructor of SplunkPushDownRule also contains spaces when invoking super():
> {code:java}
> /** Creates a SplunkPushDownRule. */
> protected SplunkPushDownRule(RelOptRuleOperand rule,
> RelBuilderFactory relBuilderFactory, String id) {
> super(rule, relBuilderFactory, "SplunkPushDownRule: " + id);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)