You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/10/07 20:11:50 UTC
[GitHub] [pinot] ddcprg opened a new pull request #7541: [issue-7499]: Add date/time function tests
ddcprg opened a new pull request #7541:
URL: https://github.com/apache/pinot/pull/7541
## Description
<!-- Add a description of your PR here.
A good description should include pointers to an issue or design document, etc.
-->
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on a change in pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg commented on a change in pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#discussion_r741708400
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java
##########
@@ -410,21 +408,4 @@ public TimeUnit getTimeUnit() {
return null;
}
}
-
Review comment:
This code is deprecated and it doesn't look like is used anywhere in Pinot - I've checked for the string version of the method names in case reflection was used. I don't think projects other than Pinot should be using this class, I've searched in both Trino and Presto and the class doesn't seem to be in use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-966655272
I can see the Joda Interval class is used in the contract of quite few places. Replacing those won't be straightforward, the author suggests using Threeten-Extra. Are we happy with this? I'll release the PR which contains only tests and few small changes and the actual migration can be done in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-966655272
I can see the Joda Interval class is used in the contract of quite few places. Replacing those won't be straight forward, the author suggests using Threeten-Extra. Are we happy with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg closed pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg closed pull request #7541:
URL: https://github.com/apache/pinot/pull/7541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7541](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ad2c141) into [master](https://codecov.io/gh/apache/pinot/commit/471d16cf5d835f41293b09d991e3d279a0b9dc1d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (471d16c) will **decrease** coverage by `43.60%`.
> The diff coverage is `75.00%`.
> :exclamation: Current head ad2c141 differs from pull request most recent head 8aa6768. Consider uploading reports for the commit 8aa6768 to get more accurate results
[](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7541 +/- ##
=============================================
- Coverage 71.60% 27.99% -43.61%
=============================================
Files 1560 1551 -9
Lines 79039 78697 -342
Branches 11702 11664 -38
=============================================
- Hits 56596 22032 -34564
- Misses 18634 54683 +36049
+ Partials 3809 1982 -1827
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `27.99% <75.00%> (+0.11%)` | :arrow_up: |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `11.39% <75.00%> (-87.24%)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/common/tier/Tier.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/BigDecimalUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQmlnRGVjaW1hbFV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/spi/config/table/TableType.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RhYmxlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/readers/FileFormat.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9yZWFkZXJzL0ZpbGVGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...org/apache/pinot/spi/config/table/QuotaConfig.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1F1b3RhQ29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1104 more](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [471d16c...8aa6768](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7541](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f70e8) into [master](https://codecov.io/gh/apache/pinot/commit/70374e2be54aeb2bd64d5d9759e5beff62d4c81a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70374e2) will **decrease** coverage by `43.09%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7541 +/- ##
=============================================
- Coverage 72.00% 28.91% -43.10%
=============================================
Files 1523 1514 -9
Lines 75509 75337 -172
Branches 11004 11002 -2
=============================================
- Hits 54373 21782 -32591
- Misses 17480 51563 +34083
+ Partials 3656 1992 -1664
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `28.91% <60.00%> (-0.07%)` | :arrow_down: |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `8.00% <60.00%> (-90.62%)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/common/tier/Tier.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/BigDecimalUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQmlnRGVjaW1hbFV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/spi/config/table/TableType.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RhYmxlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/readers/FileFormat.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9yZWFkZXJzL0ZpbGVGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...org/apache/pinot/spi/config/table/QuotaConfig.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1F1b3RhQ29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1065 more](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70374e2...51f70e8](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on pull request #7541: [issue-7499]: Add date/time function tests
Posted by GitBox <gi...@apache.org>.
ddcprg commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938120929
Fixes #7499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7541](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8aa6768) into [master](https://codecov.io/gh/apache/pinot/commit/471d16cf5d835f41293b09d991e3d279a0b9dc1d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (471d16c) will **decrease** coverage by `6.50%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7541 +/- ##
============================================
- Coverage 71.60% 65.09% -6.51%
+ Complexity 3884 3881 -3
============================================
Files 1560 1514 -46
Lines 79039 77191 -1848
Branches 11702 11502 -200
============================================
- Hits 56596 50251 -6345
- Misses 18634 23362 +4728
+ Partials 3809 3578 -231
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `68.53% <100.00%> (-0.03%)` | :arrow_down: |
| unittests2 | `14.71% <0.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `100.00% <100.00%> (+1.36%)` | :arrow_up: |
| [...a/org/apache/pinot/common/metrics/MinionMeter.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/apache/pinot/common/metrics/ControllerMeter.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Db250cm9sbGVyTWV0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/pinot/common/messages/SegmentReloadMessage.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWVzc2FnZXMvU2VnbWVudFJlbG9hZE1lc3NhZ2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pinot/core/data/manager/realtime/TimerService.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvVGltZXJTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pinot/minion/exception/TaskCancelledException.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vZXhjZXB0aW9uL1Rhc2tDYW5jZWxsZWRFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...not/common/exception/HttpErrorStatusException.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL0h0dHBFcnJvclN0YXR1c0V4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t/core/startree/plan/StarTreeDocIdSetPlanNode.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9wbGFuL1N0YXJUcmVlRG9jSWRTZXRQbGFuTm9kZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [353 more](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [471d16c...8aa6768](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-981029028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7541](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f70e8) into [master](https://codecov.io/gh/apache/pinot/commit/70374e2be54aeb2bd64d5d9759e5beff62d4c81a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70374e2) will **decrease** coverage by `43.09%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7541 +/- ##
=============================================
- Coverage 72.00% 28.91% -43.10%
=============================================
Files 1523 1514 -9
Lines 75509 75337 -172
Branches 11004 11002 -2
=============================================
- Hits 54373 21782 -32591
- Misses 17480 51563 +34083
+ Partials 3656 1992 -1664
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `28.91% <60.00%> (-0.07%)` | :arrow_down: |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `8.00% <60.00%> (-90.62%)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/common/tier/Tier.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/BigDecimalUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQmlnRGVjaW1hbFV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/spi/config/table/TableType.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RhYmxlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/readers/FileFormat.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9yZWFkZXJzL0ZpbGVGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...org/apache/pinot/spi/config/table/QuotaConfig.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1F1b3RhQ29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1065 more](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70374e2...51f70e8](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-947973700
@siddharthteotia there will be incompatibilities. I was thinking whether a new config property could be introduced to select the compatibility mode so existing queries can still work with Joda formats and eventually migrated to use Java formats if needed, I'm not sure how easy introducing the setting would be as I'm still not very familiar with the code and I can see all the query functions are defined as static methods.
With regards to other types, they are supported in Java with slightly different names: a Timestamp is an Instant and and Instant can be timezoned to convert it into a ZonedDateTime. Intervals are represented with Period and Duration.
I will edit the PR description to include more details later on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-981029028
@richardstartin @siddharthteotia is it worth keeping working on this? I'll decline the PR if not, I don't like to keep open if it's not going to be merged. Otherwise, I'll rebase and wait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on a change in pull request #7541: [issue-7499]: Add date/time function tests
Posted by GitBox <gi...@apache.org>.
ddcprg commented on a change in pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#discussion_r724510870
##########
File path: pinot-common/src/test/java/org/apache/pinot/common/function/scalar/DateTimeFunctionsTest.java
##########
@@ -0,0 +1,748 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.function.scalar;
+
+import java.sql.Timestamp;
+import java.time.Clock;
+import java.time.Instant;
+import java.time.ZoneOffset;
+import org.joda.time.DateTimeZone;
+import org.testng.Assert;
+import org.testng.annotations.BeforeTest;
+import org.testng.annotations.Test;
+
+import static java.util.concurrent.TimeUnit.*;
+
+
+public class DateTimeFunctionsTest {
+
+ @BeforeTest
+ public void init() {
+ DateTimeZone.setDefault(DateTimeZone.UTC);
+ }
+
+ @Test
+ public void testToEpochSeconds() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSeconds(1609459200999L), 1609459200L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSeconds(1646092799123L), 1646092799L);
+ }
+
+ @Test
+ public void testToEpochMinutes() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutes(1609459200999L), 26824320L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutes(1646092799123L), 27434879L);
+ }
+
+ @Test
+ public void testToEpochHours() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHours(1609459200999L), 447072L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHours(1646092799123L), 457247L);
+ }
+
+ @Test
+ public void testToEpochDays() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDays(1609459200999L), 18628L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDays(1646092799123L), 19051L);
+ }
+
+ @Test
+ public void testToEpochSecondsRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsRounded(1609459200999L, 1000), 1609459000L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsRounded(1646092799123L, 5), 1646092795L);
+ }
+
+ @Test
+ public void testToEpochMinutesRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesRounded(1609459200999L, 50), 26824300L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesRounded(1646092799123L, 2), 27434878L);
+ }
+
+ @Test
+ public void testToEpochHoursRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursRounded(1609459200999L, 2), 447072L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursRounded(1646092799123L, 4), 457244L);
+ }
+
+ @Test
+ public void testToEpochDaysRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysRounded(1609459200999L, 32), 18624L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysRounded(1646092799123L, 64), 19008L);
+ }
+
+ @Test
+ public void testToEpochSecondsBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsBucket(1609459200999L, 1000), 1609459L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsBucket(1646092799123L, 5), 329218559L);
+ }
+
+ @Test
+ public void testToEpochMinutesBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesBucket(1609459200999L, 50), 536486L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesBucket(1646092799123L, 2), 13717439L);
+ }
+
+ @Test
+ public void testToEpochHoursBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursBucket(1609459200999L, 2), 223536L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursBucket(1646092799123L, 4), 114311L);
+ }
+
+ @Test
+ public void testToEpochDaysBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysBucket(1609459200999L, 32), 582L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysBucket(1646092799123L, 64), 297L);
+ }
+
+ @Test
+ public void testFromEpochSeconds() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochSeconds(1609459200L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochSeconds(1646092799L), 1646092799000L);
+ }
+
+ @Test
+ public void testFromEpochMinutes() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutes(26824320L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutes(27434879L), 1646092740000L);
+ }
+
+ @Test
+ public void testFromEpochHours() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochHours(447072L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochHours(457247L), 1646089200000L);
+ }
+
+ @Test
+ public void testFromEpochDays() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochDays(18628L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochDays(19051L), 1646006400000L);
+ }
+
+ @Test
+ public void testFromEpochSecondsBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochSecondsBucket(1609459L, 1000), 1609459000000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochSecondsBucket(329218559L, 5), 1646092795000L);
+ }
+
+ @Test
+ public void testFromEpochMinutesBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutesBucket(536486L, 50), 1609458000000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutesBucket(13717439L, 2), 1646092680000L);
+ }
+
+ @Test
+ public void testFromEpochHoursBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochHoursBucket(223536L, 2), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochHoursBucket(114311L, 4), 1646078400000L);
+ }
+
+ @Test
+ public void fromEpochDaysBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochDaysBucket(582L, 32), 1609113600000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochDaysBucket(297L, 64), 1642291200000L);
+ }
+
+ @Test
+ public void testToTimestamp() {
+ Assert.assertEquals(
+ DateTimeFunctions.toTimestamp(1633375617536L), new Timestamp(1633375617536L));
+ }
+
+ @Test
+ public void testFromTimestamp() {
+ Assert.assertEquals(
+ DateTimeFunctions.fromTimestamp(new Timestamp(1633375617536L)), 1633375617536L);
+ }
+
+ @Test
+ public void toDateTime() {
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ "2021-10-04T19:34:58.332 UTC");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "yyyy-MM-dd'T'HH:mm:ss.SSSZ"),
+ "2021-10-04T19:34:58.332+0000");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ "2021-10-04T19:34:58.332 UTC");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1325376000000L, "xxxx"), "2011"); // 2012-01-01 00:00:00
+ Assert.assertEquals(DateTimeFunctions.toDateTime(1325376000000L, "yyyy"), "2012");
+ Assert.assertEquals(DateTimeFunctions.toDateTime(1325376000000L, "YYYY"), "2012");
+ // TODO more formats, all formats
Review comment:
Add all possible formats
##########
File path: pinot-common/src/test/java/org/apache/pinot/common/function/scalar/DateTimeFunctionsTest.java
##########
@@ -0,0 +1,748 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.function.scalar;
+
+import java.sql.Timestamp;
+import java.time.Clock;
+import java.time.Instant;
+import java.time.ZoneOffset;
+import org.joda.time.DateTimeZone;
+import org.testng.Assert;
+import org.testng.annotations.BeforeTest;
+import org.testng.annotations.Test;
+
+import static java.util.concurrent.TimeUnit.*;
+
+
+public class DateTimeFunctionsTest {
+
+ @BeforeTest
+ public void init() {
+ DateTimeZone.setDefault(DateTimeZone.UTC);
+ }
+
+ @Test
+ public void testToEpochSeconds() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSeconds(1609459200999L), 1609459200L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSeconds(1646092799123L), 1646092799L);
+ }
+
+ @Test
+ public void testToEpochMinutes() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutes(1609459200999L), 26824320L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutes(1646092799123L), 27434879L);
+ }
+
+ @Test
+ public void testToEpochHours() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHours(1609459200999L), 447072L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHours(1646092799123L), 457247L);
+ }
+
+ @Test
+ public void testToEpochDays() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDays(1609459200999L), 18628L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDays(1646092799123L), 19051L);
+ }
+
+ @Test
+ public void testToEpochSecondsRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsRounded(1609459200999L, 1000), 1609459000L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsRounded(1646092799123L, 5), 1646092795L);
+ }
+
+ @Test
+ public void testToEpochMinutesRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesRounded(1609459200999L, 50), 26824300L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesRounded(1646092799123L, 2), 27434878L);
+ }
+
+ @Test
+ public void testToEpochHoursRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursRounded(1609459200999L, 2), 447072L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursRounded(1646092799123L, 4), 457244L);
+ }
+
+ @Test
+ public void testToEpochDaysRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysRounded(1609459200999L, 32), 18624L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysRounded(1646092799123L, 64), 19008L);
+ }
+
+ @Test
+ public void testToEpochSecondsBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsBucket(1609459200999L, 1000), 1609459L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsBucket(1646092799123L, 5), 329218559L);
+ }
+
+ @Test
+ public void testToEpochMinutesBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesBucket(1609459200999L, 50), 536486L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesBucket(1646092799123L, 2), 13717439L);
+ }
+
+ @Test
+ public void testToEpochHoursBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursBucket(1609459200999L, 2), 223536L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursBucket(1646092799123L, 4), 114311L);
+ }
+
+ @Test
+ public void testToEpochDaysBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysBucket(1609459200999L, 32), 582L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysBucket(1646092799123L, 64), 297L);
+ }
+
+ @Test
+ public void testFromEpochSeconds() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochSeconds(1609459200L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochSeconds(1646092799L), 1646092799000L);
+ }
+
+ @Test
+ public void testFromEpochMinutes() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutes(26824320L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutes(27434879L), 1646092740000L);
+ }
+
+ @Test
+ public void testFromEpochHours() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochHours(447072L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochHours(457247L), 1646089200000L);
+ }
+
+ @Test
+ public void testFromEpochDays() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochDays(18628L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochDays(19051L), 1646006400000L);
+ }
+
+ @Test
+ public void testFromEpochSecondsBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochSecondsBucket(1609459L, 1000), 1609459000000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochSecondsBucket(329218559L, 5), 1646092795000L);
+ }
+
+ @Test
+ public void testFromEpochMinutesBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutesBucket(536486L, 50), 1609458000000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutesBucket(13717439L, 2), 1646092680000L);
+ }
+
+ @Test
+ public void testFromEpochHoursBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochHoursBucket(223536L, 2), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochHoursBucket(114311L, 4), 1646078400000L);
+ }
+
+ @Test
+ public void fromEpochDaysBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochDaysBucket(582L, 32), 1609113600000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochDaysBucket(297L, 64), 1642291200000L);
+ }
+
+ @Test
+ public void testToTimestamp() {
+ Assert.assertEquals(
+ DateTimeFunctions.toTimestamp(1633375617536L), new Timestamp(1633375617536L));
+ }
+
+ @Test
+ public void testFromTimestamp() {
+ Assert.assertEquals(
+ DateTimeFunctions.fromTimestamp(new Timestamp(1633375617536L)), 1633375617536L);
+ }
+
+ @Test
+ public void toDateTime() {
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ "2021-10-04T19:34:58.332 UTC");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "yyyy-MM-dd'T'HH:mm:ss.SSSZ"),
+ "2021-10-04T19:34:58.332+0000");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ "2021-10-04T19:34:58.332 UTC");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1325376000000L, "xxxx"), "2011"); // 2012-01-01 00:00:00
+ Assert.assertEquals(DateTimeFunctions.toDateTime(1325376000000L, "yyyy"), "2012");
+ Assert.assertEquals(DateTimeFunctions.toDateTime(1325376000000L, "YYYY"), "2012");
+ // TODO more formats, all formats
+ }
+
+ @Test
+ public void testFromDateTime() {
+ Assert.assertEquals(
+ DateTimeFunctions.fromDateTime("2021-10-04T19:34:58.332 UTC", "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ 1633376098332L);
+ Assert.assertEquals(
+ DateTimeFunctions.fromDateTime("2021-10-04T19:34:58.332+0000", "yyyy-MM-dd'T'HH:mm:ss.SSSZ"),
+ 1633376098332L);
+ Assert.assertEquals(
+ DateTimeFunctions.fromDateTime("2021-10-04T19:34:58.332 UTC", "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ 1633376098332L);
+ Assert.assertEquals(
+ DateTimeFunctions.fromDateTime("2011", "xxxx"), 1294012800000L); // strange case, reverse operation is not exact
+ Assert.assertEquals(DateTimeFunctions.fromDateTime("2012", "yyyy"), 1325376000000L);
+ Assert.assertEquals(DateTimeFunctions.fromDateTime("2012", "YYYY"), 1325376000000L);
+ // TODO more formats, all formats
Review comment:
Add all possible formats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-966655272
I can see the Joda Interval class is used in the contract of quite few places. Replacing those won't be straightforward, the author suggests using Threeten-Extra. Are we happy with this? I'll release the PR which contains only tests and few small changes and the actual migration can be made in another PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on a change in pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg commented on a change in pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#discussion_r741708400
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java
##########
@@ -410,21 +408,4 @@ public TimeUnit getTimeUnit() {
return null;
}
}
-
Review comment:
This code is deprecated and it doesn't look like is used anywhere in Pinot - I've checked for the string version of the method names in case reflection was used. I don't think projects other than Pinot should be using this class, I've searched in both Trino and Presto and the class doesn't seem to be in use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on a change in pull request #7541: [issue-7499]: Add date/time function tests
Posted by GitBox <gi...@apache.org>.
ddcprg commented on a change in pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#discussion_r724510870
##########
File path: pinot-common/src/test/java/org/apache/pinot/common/function/scalar/DateTimeFunctionsTest.java
##########
@@ -0,0 +1,748 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.function.scalar;
+
+import java.sql.Timestamp;
+import java.time.Clock;
+import java.time.Instant;
+import java.time.ZoneOffset;
+import org.joda.time.DateTimeZone;
+import org.testng.Assert;
+import org.testng.annotations.BeforeTest;
+import org.testng.annotations.Test;
+
+import static java.util.concurrent.TimeUnit.*;
+
+
+public class DateTimeFunctionsTest {
+
+ @BeforeTest
+ public void init() {
+ DateTimeZone.setDefault(DateTimeZone.UTC);
+ }
+
+ @Test
+ public void testToEpochSeconds() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSeconds(1609459200999L), 1609459200L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSeconds(1646092799123L), 1646092799L);
+ }
+
+ @Test
+ public void testToEpochMinutes() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutes(1609459200999L), 26824320L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutes(1646092799123L), 27434879L);
+ }
+
+ @Test
+ public void testToEpochHours() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHours(1609459200999L), 447072L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHours(1646092799123L), 457247L);
+ }
+
+ @Test
+ public void testToEpochDays() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDays(1609459200999L), 18628L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDays(1646092799123L), 19051L);
+ }
+
+ @Test
+ public void testToEpochSecondsRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsRounded(1609459200999L, 1000), 1609459000L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsRounded(1646092799123L, 5), 1646092795L);
+ }
+
+ @Test
+ public void testToEpochMinutesRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesRounded(1609459200999L, 50), 26824300L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesRounded(1646092799123L, 2), 27434878L);
+ }
+
+ @Test
+ public void testToEpochHoursRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursRounded(1609459200999L, 2), 447072L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursRounded(1646092799123L, 4), 457244L);
+ }
+
+ @Test
+ public void testToEpochDaysRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysRounded(1609459200999L, 32), 18624L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysRounded(1646092799123L, 64), 19008L);
+ }
+
+ @Test
+ public void testToEpochSecondsBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsBucket(1609459200999L, 1000), 1609459L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsBucket(1646092799123L, 5), 329218559L);
+ }
+
+ @Test
+ public void testToEpochMinutesBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesBucket(1609459200999L, 50), 536486L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesBucket(1646092799123L, 2), 13717439L);
+ }
+
+ @Test
+ public void testToEpochHoursBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursBucket(1609459200999L, 2), 223536L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursBucket(1646092799123L, 4), 114311L);
+ }
+
+ @Test
+ public void testToEpochDaysBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysBucket(1609459200999L, 32), 582L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysBucket(1646092799123L, 64), 297L);
+ }
+
+ @Test
+ public void testFromEpochSeconds() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochSeconds(1609459200L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochSeconds(1646092799L), 1646092799000L);
+ }
+
+ @Test
+ public void testFromEpochMinutes() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutes(26824320L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutes(27434879L), 1646092740000L);
+ }
+
+ @Test
+ public void testFromEpochHours() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochHours(447072L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochHours(457247L), 1646089200000L);
+ }
+
+ @Test
+ public void testFromEpochDays() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochDays(18628L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochDays(19051L), 1646006400000L);
+ }
+
+ @Test
+ public void testFromEpochSecondsBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochSecondsBucket(1609459L, 1000), 1609459000000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochSecondsBucket(329218559L, 5), 1646092795000L);
+ }
+
+ @Test
+ public void testFromEpochMinutesBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutesBucket(536486L, 50), 1609458000000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutesBucket(13717439L, 2), 1646092680000L);
+ }
+
+ @Test
+ public void testFromEpochHoursBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochHoursBucket(223536L, 2), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochHoursBucket(114311L, 4), 1646078400000L);
+ }
+
+ @Test
+ public void fromEpochDaysBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochDaysBucket(582L, 32), 1609113600000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochDaysBucket(297L, 64), 1642291200000L);
+ }
+
+ @Test
+ public void testToTimestamp() {
+ Assert.assertEquals(
+ DateTimeFunctions.toTimestamp(1633375617536L), new Timestamp(1633375617536L));
+ }
+
+ @Test
+ public void testFromTimestamp() {
+ Assert.assertEquals(
+ DateTimeFunctions.fromTimestamp(new Timestamp(1633375617536L)), 1633375617536L);
+ }
+
+ @Test
+ public void toDateTime() {
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ "2021-10-04T19:34:58.332 UTC");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "yyyy-MM-dd'T'HH:mm:ss.SSSZ"),
+ "2021-10-04T19:34:58.332+0000");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ "2021-10-04T19:34:58.332 UTC");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1325376000000L, "xxxx"), "2011"); // 2012-01-01 00:00:00
+ Assert.assertEquals(DateTimeFunctions.toDateTime(1325376000000L, "yyyy"), "2012");
+ Assert.assertEquals(DateTimeFunctions.toDateTime(1325376000000L, "YYYY"), "2012");
+ // TODO more formats, all formats
Review comment:
Add all possible formats
##########
File path: pinot-common/src/test/java/org/apache/pinot/common/function/scalar/DateTimeFunctionsTest.java
##########
@@ -0,0 +1,748 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.function.scalar;
+
+import java.sql.Timestamp;
+import java.time.Clock;
+import java.time.Instant;
+import java.time.ZoneOffset;
+import org.joda.time.DateTimeZone;
+import org.testng.Assert;
+import org.testng.annotations.BeforeTest;
+import org.testng.annotations.Test;
+
+import static java.util.concurrent.TimeUnit.*;
+
+
+public class DateTimeFunctionsTest {
+
+ @BeforeTest
+ public void init() {
+ DateTimeZone.setDefault(DateTimeZone.UTC);
+ }
+
+ @Test
+ public void testToEpochSeconds() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSeconds(1609459200999L), 1609459200L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSeconds(1646092799123L), 1646092799L);
+ }
+
+ @Test
+ public void testToEpochMinutes() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutes(1609459200999L), 26824320L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutes(1646092799123L), 27434879L);
+ }
+
+ @Test
+ public void testToEpochHours() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHours(1609459200999L), 447072L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHours(1646092799123L), 457247L);
+ }
+
+ @Test
+ public void testToEpochDays() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDays(1609459200999L), 18628L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDays(1646092799123L), 19051L);
+ }
+
+ @Test
+ public void testToEpochSecondsRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsRounded(1609459200999L, 1000), 1609459000L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsRounded(1646092799123L, 5), 1646092795L);
+ }
+
+ @Test
+ public void testToEpochMinutesRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesRounded(1609459200999L, 50), 26824300L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesRounded(1646092799123L, 2), 27434878L);
+ }
+
+ @Test
+ public void testToEpochHoursRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursRounded(1609459200999L, 2), 447072L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursRounded(1646092799123L, 4), 457244L);
+ }
+
+ @Test
+ public void testToEpochDaysRounded() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysRounded(1609459200999L, 32), 18624L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysRounded(1646092799123L, 64), 19008L);
+ }
+
+ @Test
+ public void testToEpochSecondsBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsBucket(1609459200999L, 1000), 1609459L);
+ Assert.assertEquals(DateTimeFunctions.toEpochSecondsBucket(1646092799123L, 5), 329218559L);
+ }
+
+ @Test
+ public void testToEpochMinutesBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesBucket(1609459200999L, 50), 536486L);
+ Assert.assertEquals(DateTimeFunctions.toEpochMinutesBucket(1646092799123L, 2), 13717439L);
+ }
+
+ @Test
+ public void testToEpochHoursBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursBucket(1609459200999L, 2), 223536L);
+ Assert.assertEquals(DateTimeFunctions.toEpochHoursBucket(1646092799123L, 4), 114311L);
+ }
+
+ @Test
+ public void testToEpochDaysBucket() {
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysBucket(1609459200999L, 32), 582L);
+ Assert.assertEquals(DateTimeFunctions.toEpochDaysBucket(1646092799123L, 64), 297L);
+ }
+
+ @Test
+ public void testFromEpochSeconds() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochSeconds(1609459200L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochSeconds(1646092799L), 1646092799000L);
+ }
+
+ @Test
+ public void testFromEpochMinutes() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutes(26824320L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutes(27434879L), 1646092740000L);
+ }
+
+ @Test
+ public void testFromEpochHours() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochHours(447072L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochHours(457247L), 1646089200000L);
+ }
+
+ @Test
+ public void testFromEpochDays() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochDays(18628L), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochDays(19051L), 1646006400000L);
+ }
+
+ @Test
+ public void testFromEpochSecondsBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochSecondsBucket(1609459L, 1000), 1609459000000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochSecondsBucket(329218559L, 5), 1646092795000L);
+ }
+
+ @Test
+ public void testFromEpochMinutesBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutesBucket(536486L, 50), 1609458000000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochMinutesBucket(13717439L, 2), 1646092680000L);
+ }
+
+ @Test
+ public void testFromEpochHoursBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochHoursBucket(223536L, 2), 1609459200000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochHoursBucket(114311L, 4), 1646078400000L);
+ }
+
+ @Test
+ public void fromEpochDaysBucket() {
+ Assert.assertEquals(DateTimeFunctions.fromEpochDaysBucket(582L, 32), 1609113600000L);
+ Assert.assertEquals(DateTimeFunctions.fromEpochDaysBucket(297L, 64), 1642291200000L);
+ }
+
+ @Test
+ public void testToTimestamp() {
+ Assert.assertEquals(
+ DateTimeFunctions.toTimestamp(1633375617536L), new Timestamp(1633375617536L));
+ }
+
+ @Test
+ public void testFromTimestamp() {
+ Assert.assertEquals(
+ DateTimeFunctions.fromTimestamp(new Timestamp(1633375617536L)), 1633375617536L);
+ }
+
+ @Test
+ public void toDateTime() {
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ "2021-10-04T19:34:58.332 UTC");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "yyyy-MM-dd'T'HH:mm:ss.SSSZ"),
+ "2021-10-04T19:34:58.332+0000");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1633376098332L, "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ "2021-10-04T19:34:58.332 UTC");
+ Assert.assertEquals(
+ DateTimeFunctions.toDateTime(1325376000000L, "xxxx"), "2011"); // 2012-01-01 00:00:00
+ Assert.assertEquals(DateTimeFunctions.toDateTime(1325376000000L, "yyyy"), "2012");
+ Assert.assertEquals(DateTimeFunctions.toDateTime(1325376000000L, "YYYY"), "2012");
+ // TODO more formats, all formats
+ }
+
+ @Test
+ public void testFromDateTime() {
+ Assert.assertEquals(
+ DateTimeFunctions.fromDateTime("2021-10-04T19:34:58.332 UTC", "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ 1633376098332L);
+ Assert.assertEquals(
+ DateTimeFunctions.fromDateTime("2021-10-04T19:34:58.332+0000", "yyyy-MM-dd'T'HH:mm:ss.SSSZ"),
+ 1633376098332L);
+ Assert.assertEquals(
+ DateTimeFunctions.fromDateTime("2021-10-04T19:34:58.332 UTC", "YYYY-MM-dd'T'HH:mm:ss.SSS z"),
+ 1633376098332L);
+ Assert.assertEquals(
+ DateTimeFunctions.fromDateTime("2011", "xxxx"), 1294012800000L); // strange case, reverse operation is not exact
+ Assert.assertEquals(DateTimeFunctions.fromDateTime("2012", "yyyy"), 1325376000000L);
+ Assert.assertEquals(DateTimeFunctions.fromDateTime("2012", "YYYY"), 1325376000000L);
+ // TODO more formats, all formats
Review comment:
Add all possible formats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-947973700
@siddharthteotia there will be incompatibilities. I was thinking whether a new config property could be introduced to select the compatibility mode so existing queries can still work with Joda formats and eventually migrated to use Java formats if needed, I'm not sure how easy introducing the setting would be as I'm still not very familiar with the code and I can see all thee methods are static.
With regards to other types, they are supported in Java with slightly different names: a Timestamp is an Instant and and Instant can be timezoned to convert it into a ZonedDateTime. Intervals are represented with Period and Duration.
I will edit the PR description to include more details later on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7541](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8aa6768) into [master](https://codecov.io/gh/apache/pinot/commit/471d16cf5d835f41293b09d991e3d279a0b9dc1d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (471d16c) will **decrease** coverage by `3.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7541 +/- ##
============================================
- Coverage 71.60% 68.53% -3.08%
+ Complexity 3884 3801 -83
============================================
Files 1560 1165 -395
Lines 79039 56745 -22294
Branches 11702 8706 -2996
============================================
- Hits 56596 38890 -17706
+ Misses 18634 15094 -3540
+ Partials 3809 2761 -1048
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `68.53% <100.00%> (-0.03%)` | :arrow_down: |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `100.00% <100.00%> (+1.36%)` | :arrow_up: |
| [...a/org/apache/pinot/common/metrics/MinionMeter.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25NZXRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...g/apache/pinot/common/metrics/ControllerMeter.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Db250cm9sbGVyTWV0ZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/BrokerQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJRdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pinot/common/metrics/MinionQueryPhase.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9NaW5pb25RdWVyeVBoYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/pinot/common/messages/SegmentReloadMessage.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWVzc2FnZXMvU2VnbWVudFJlbG9hZE1lc3NhZ2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...pinot/core/data/manager/realtime/TimerService.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvVGltZXJTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...not/common/exception/HttpErrorStatusException.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL0h0dHBFcnJvclN0YXR1c0V4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t/core/startree/plan/StarTreeDocIdSetPlanNode.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS9wbGFuL1N0YXJUcmVlRG9jSWRTZXRQbGFuTm9kZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ot/common/restlet/resources/TableMetadataInfo.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzdGxldC9yZXNvdXJjZXMvVGFibGVNZXRhZGF0YUluZm8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [597 more](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [471d16c...8aa6768](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-940676370
Will this be backwards compatible ? Also, will this support potential future enhancement -- say if we want to support TIMESTAMP type with timezone or let's say INTERVAL type or will we find ourselves using Joda or something similar again ?
Also for reference purposes, I suggest mentioning any points comparing Joda and Java time APIs in the PR description to highlight if there are any functional or perf improvements/differences
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938120929
helps fixing #7499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7541](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f70e8) into [master](https://codecov.io/gh/apache/pinot/commit/70374e2be54aeb2bd64d5d9759e5beff62d4c81a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70374e2) will **decrease** coverage by `39.69%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7541 +/- ##
=============================================
- Coverage 72.00% 32.31% -39.70%
=============================================
Files 1523 1514 -9
Lines 75509 75337 -172
Branches 11004 11002 -2
=============================================
- Hits 54373 24346 -30027
- Misses 17480 48898 +31418
+ Partials 3656 2093 -1563
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `30.68% <60.00%> (+0.17%)` | :arrow_up: |
| integration2 | `28.91% <60.00%> (-0.07%)` | :arrow_down: |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `8.00% <60.00%> (-90.62%)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/common/tier/Tier.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/BigDecimalUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQmlnRGVjaW1hbFV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/spi/config/table/TableType.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RhYmxlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/readers/FileFormat.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9yZWFkZXJzL0ZpbGVGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...org/apache/pinot/spi/config/table/QuotaConfig.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1F1b3RhQ29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1011 more](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70374e2...51f70e8](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on a change in pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg commented on a change in pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#discussion_r741708400
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java
##########
@@ -410,21 +408,4 @@ public TimeUnit getTimeUnit() {
return null;
}
}
-
Review comment:
This code is deprecated and it doesn't look like is used anywhere in Pinot - I've checked for the string version of the method names in case reflection was used. I don't think projects other than Pinot should be using this class, I've searched in both Trino and Presto and the class doesn't seem to be in use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7541](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d6cd17a) into [master](https://codecov.io/gh/apache/pinot/commit/b2add149688d28150561c6933df6f753db5173a5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2add14) will **decrease** coverage by `42.90%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7541 +/- ##
=============================================
- Coverage 70.60% 27.70% -42.91%
=============================================
Files 1578 1570 -8
Lines 80248 80030 -218
Branches 11914 11904 -10
=============================================
- Hits 56662 22169 -34493
- Misses 19721 55846 +36125
+ Partials 3865 2015 -1850
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `27.70% <66.66%> (?)` | |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `25.20% <0.00%> (-50.41%)` | :arrow_down: |
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `11.39% <75.00%> (-87.24%)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/common/tier/Tier.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/BigDecimalUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQmlnRGVjaW1hbFV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/spi/config/table/TableType.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RhYmxlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/readers/FileFormat.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9yZWFkZXJzL0ZpbGVGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1158 more](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b2add14...d6cd17a](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-966655272
I can see the Joda Interval class is used in the contract of quite few places. Replacing those won't be straightforward, the author suggests using Threeten-Extra. Are we happy with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
richardstartin commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-947991703
The reason to migrate from joda time is not really for performance, though within the JDK `java.time` enjoys some privileges, but that the author of the library later implemented `java.time` and was [suggesting to stop using joda time](https://blog.joda.org/2014/11/converting-from-joda-time-to-javatime.html) in _2014_. That was 7 years ago! That said, joda-time **is** still maintained and migrating is not critical for e.g. security reasons. There are some small incompatibilities in the date time format, which can translated on the fly. Some of this is mentioned on #7499.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-981029028
@richardstartin @siddharthteotia is it worth keep working on this? I'll decline the PR if not, I don't like to keep open if it's not going to be merged. Otherwise, I'll rebase and wait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7541](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51f70e8) into [master](https://codecov.io/gh/apache/pinot/commit/70374e2be54aeb2bd64d5d9759e5beff62d4c81a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70374e2) will **decrease** coverage by `39.69%`.
> The diff coverage is `60.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7541 +/- ##
=============================================
- Coverage 72.00% 32.31% -39.70%
=============================================
Files 1523 1514 -9
Lines 75509 75337 -172
Branches 11004 11002 -2
=============================================
- Hits 54373 24346 -30027
- Misses 17480 48898 +31418
+ Partials 3656 2093 -1563
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `30.68% <60.00%> (+0.17%)` | :arrow_up: |
| integration2 | `28.91% <60.00%> (-0.07%)` | :arrow_down: |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `8.00% <60.00%> (-90.62%)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/common/tier/Tier.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/BigDecimalUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQmlnRGVjaW1hbFV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/spi/config/table/TableType.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RhYmxlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/readers/FileFormat.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9yZWFkZXJzL0ZpbGVGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...org/apache/pinot/spi/config/table/QuotaConfig.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1F1b3RhQ29uZmlnLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1011 more](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70374e2...51f70e8](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on pull request #7541: [issue-7499]: Add date/time function tests
Posted by GitBox <gi...@apache.org>.
ddcprg commented on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938120929
Fixes #7499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] ddcprg commented on a change in pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
ddcprg commented on a change in pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#discussion_r741708400
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java
##########
@@ -410,21 +408,4 @@ public TimeUnit getTimeUnit() {
return null;
}
}
-
Review comment:
This code is deprecated and it doesn't look like is used anywhere in Pinot - I've checked for the string version of the method names in case reflection was used. I don't think projects other than Pinot should be using this class, I've searched in both Trino and Presto and the class doesn't seem to be in use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7541: [issue-7499]: Migrate from Joda Time to Java Time API
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7541:
URL: https://github.com/apache/pinot/pull/7541#issuecomment-938163135
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7541](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d6cd17a) into [master](https://codecov.io/gh/apache/pinot/commit/b2add149688d28150561c6933df6f753db5173a5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2add14) will **decrease** coverage by `39.82%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7541 +/- ##
=============================================
- Coverage 70.60% 30.77% -39.83%
=============================================
Files 1578 1570 -8
Lines 80248 80030 -218
Branches 11914 11904 -10
=============================================
- Hits 56662 24633 -32029
- Misses 19721 53286 +33565
+ Partials 3865 2111 -1754
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `29.23% <66.66%> (+0.19%)` | :arrow_up: |
| integration2 | `27.70% <66.66%> (?)` | |
| unittests1 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `52.03% <0.00%> (-23.58%)` | :arrow_down: |
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `11.39% <75.00%> (-87.24%)` | :arrow_down: |
| [...c/main/java/org/apache/pinot/common/tier/Tier.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/data/MetricFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/BigDecimalUtils.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQmlnRGVjaW1hbFV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...java/org/apache/pinot/common/tier/TierFactory.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdGllci9UaWVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...a/org/apache/pinot/spi/config/table/TableType.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RhYmxlVHlwZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/DimensionFieldSpec.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9EaW1lbnNpb25GaWVsZFNwZWMuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pinot/spi/data/readers/FileFormat.java](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvZGF0YS9yZWFkZXJzL0ZpbGVGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1110 more](https://codecov.io/gh/apache/pinot/pull/7541/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b2add14...d6cd17a](https://codecov.io/gh/apache/pinot/pull/7541?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org