You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/01 22:14:19 UTC
[GitHub] [superset] yardz opened a new pull request #13395: Bug chart
yardz opened a new pull request #13395:
URL: https://github.com/apache/superset/pull/13395
When entering a new chart, an error occurs and the application freezes.
The error message points out that it is because an array is expected but an object is being sent.
As shown in the image:
<img width="1680" alt="Captura de Tela 2021-03-01 às 6 55 17 PM" src="https://user-images.githubusercontent.com/1014611/109565207-e2a97d00-7ac0-11eb-8a77-c92e1ed5fecc.png">
With this fix, I started to send the object's values as an array:
<img width="659" alt="Captura de Tela 2021-03-01 às 6 57 44 PM" src="https://user-images.githubusercontent.com/1014611/109565428-361bcb00-7ac1-11eb-8608-d20b0fd7e1ac.png">
The application stopped freezing, but I was unable to test if it is working correctly:
<img width="1667" alt="Captura de Tela 2021-03-01 às 7 01 16 PM" src="https://user-images.githubusercontent.com/1014611/109565514-59467a80-7ac1-11eb-98fa-7adb9c8867e3.png">
Attention points:
- There are several incorrect typing alerts in this flow.
- Some typescript components are also incorrectly typed. (Missing properties that are being used in other components. "options" was one of those properties that was missing.
- Perhaps this fix can generate some unwanted side effects on others charts. Before deciding whether it actually solved anything, it is important to check if the others charts are working correctly.
- Component that was giving exception and freezing the application: `src/explore/components/Control.tsx`
My guess:
When activating the Feature Flag, some changes in the response of the APIS started to cause this unwanted behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13395: fix(graph): graph page error
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13395:
URL: https://github.com/apache/superset/pull/13395#issuecomment-789238490
LGTM from UI with the feature flag on and off.
Let's update the PR description and get the checks green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz closed pull request #13395: fix(graph): graph page error
Posted by GitBox <gi...@apache.org>.
yardz closed pull request #13395:
URL: https://github.com/apache/superset/pull/13395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org