You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Johnny Dong (JIRA)" <ji...@apache.org> on 2016/03/03 12:08:18 UTC
[jira] [Comment Edited] (CB-10723) iOS9.2 no audio
[ https://issues.apache.org/jira/browse/CB-10723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177674#comment-15177674 ]
Johnny Dong edited comment on CB-10723 at 3/3/16 11:07 AM:
-----------------------------------------------------------
yes notice that from your original PR which you checked in back in Jul 29, 2015 that contains the streaming: https://github.com/apache/cordova-plugin-media/commit/00ddb9372bf4c9b96ccea0dbd285499df1809277
For context, In my ionicFramework app, folder structure is:
'
root
+- www
+- app
+-app.js
+
+-content
| +- 001
| +- some-audio-file.m4a
+
+-home
+- home.module.js
+- home.controller.js
'
angularJS controller home.controller.js sets up the cordoba-plugin-media object like so:
var src = "app/content/001/some-audio-file.m4a";
var media = $cordovaMedia.newMedia(src);
as you can see i don't prefix with @"cdvfile://", and it's using relative paths from the from where app.js starts.
With the structure above in me, lets wind back a bit in CDVSound.m ln228 - 239 (void)create:(CDVInvokedUrlCommand*)command, where the player is allocated:
if (![resourceUrl isFileURL] && ![resourcePath hasPrefix:CDVFILE_PREFIX]) {
// First create an AVPlayerItem
AVPlayerItem* playerItem = [AVPlayerItem playerItemWithURL:resourceUrl];
..
..
..
// Pass the AVPlayerItem to a new player
avPlayer = [[AVPlayer alloc] initWithPlayerItem:playerItem];
Is this where the start of the problem? possibly the IF statement not recognising resourcePath? NOTE, i've actually tried passing cdvfile://" at some point during the investigation (hence the hack on ln 355).
was (Author: spudmashmedia):
yes notice that from your original PR which you checked in back in Jul 29, 2015 that contains the streaming: https://github.com/apache/cordova-plugin-media/commit/00ddb9372bf4c9b96ccea0dbd285499df1809277
For context, In my ionicFramework app, folder structure is:
root
+- www
+- app
+-app.js
+
+-content
| +- 001
| +- some-audio-file.m4a
+
+-home
+- home.module.js
+- home.controller.js
angularJS controller home.controller.js sets up the cordoba-plugin-media object like so:
var src = "app/content/001/some-audio-file.m4a";
var media = $cordovaMedia.newMedia(src);
as you can see i don't prefix with @"cdvfile://", and it's using relative paths from the from where app.js starts.
With the structure above in me, lets wind back a bit in CDVSound.m ln228 - 239 (void)create:(CDVInvokedUrlCommand*)command, where the player is allocated:
if (![resourceUrl isFileURL] && ![resourcePath hasPrefix:CDVFILE_PREFIX]) {
// First create an AVPlayerItem
AVPlayerItem* playerItem = [AVPlayerItem playerItemWithURL:resourceUrl];
..
..
..
// Pass the AVPlayerItem to a new player
avPlayer = [[AVPlayer alloc] initWithPlayerItem:playerItem];
Is this where the start of the problem? possibly the IF statement not recognising resourcePath? NOTE, i've actually tried passing cdvfile://" at some point during the investigation (hence the hack on ln 355).
> iOS9.2 no audio
> ---------------
>
> Key: CB-10723
> URL: https://issues.apache.org/jira/browse/CB-10723
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Media
> Affects Versions: 2.2.0
> Environment: IonicFramework | ngCordova | cordova-plugin-media
> Reporter: Johnny Dong
> Assignee: Omar Mefire
> Labels: easyfix, iOS, pendingPR, triaged
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> Found an issue with the latest cordova.plugin.media whilst i was putting together a IonicFramework app for iOS 9.2.1 (iPhone 6s) to play an M4A file.
> The iOS logs would show:
> - Found resource '[path].m4a' in the web folder.
> Playing audio sample '[path].m4a'
> - Playing stream with AVPlayer & custom rate
> but no sound (both simulator + device)
> Debugging in Xcode, ./cordova-plugin-media/src/ios/CDVSound.m,ln 352 + 355 appears to be the culprit.
> Instead of using "avPlayer" which doesn't appear to have a handle to the sound resource, switching to "audioFile.player" appears to resolve the sound issue.
> *** ./cordova-plugin-media/src/ios/CDVSound.m,ln 352
> from:
> [avPlayer setRate:customRate];
> to:
> [audioFile.player setRate:customRate];
> *** ./cordova-plugin-media/src/ios/CDVSound.m,ln 355
> from:
> [avPlayer play];
> to:
> [audioFile.player play];
> NOTE: I've yet to create a PR as I have not signed the Apache ICLA, however i've committed a code in my personal fork and happy for somebody to have a look at it and submit on my behalf:
> https://github.com/spudmashmedia/cordova-plugin-media/commit/946ffcf569cbaa22241e8ec00f11b4a52a0c6809
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org