You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Vladimir Sitnikov (JIRA)" <ji...@apache.org> on 2018/08/20 21:00:00 UTC
[jira] [Commented] (CALCITE-2433) SqlAdvisor.getCompletionHints is
hard-coded for " quoting
[ https://issues.apache.org/jira/browse/CALCITE-2433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586519#comment-16586519 ]
Vladimir Sitnikov commented on CALCITE-2433:
--------------------------------------------
Even though there are no that many reviews, I would consider [the PR|https://github.com/apache/calcite/pull/773] mergeable (modulo squash/rebase): it does fix bugs, and it does not impact the core functionality (==even the worst consequences should not break much).
> SqlAdvisor.getCompletionHints is hard-coded for " quoting
> ---------------------------------------------------------
>
> Key: CALCITE-2433
> URL: https://issues.apache.org/jira/browse/CALCITE-2433
> Project: Calcite
> Issue Type: Bug
> Components: core
> Affects Versions: 1.17.0
> Reporter: Vladimir Sitnikov
> Assignee: Julian Hyde
> Priority: Major
>
> Relevant source:
> {code:java}
> boolean quoted = false;
> while (wordStart > 0
> && Character.isJavaIdentifierPart(sql.charAt(wordStart - 1))) {
> --wordStart;
> }
> if ((wordStart > 0)
> && (sql.charAt(wordStart - 1) == '"')) { // <-- It should get quoting from the connection
> quoted = true;
> --wordStart;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)