[PR] Refactor agent e2e test pom for jdbc [shardingsphere]

["jiangML (via GitHub)" <gi...@apache.org>]

jiangML opened a new pull request, #38636:
URL: https://github.com/apache/shardingsphere/pull/38636

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     - Refactor agent e2e test pom for jdbc
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor agent e2e test pom for jdbc [shardingsphere]

["jiangML (via GitHub)" <gi...@apache.org>]

jiangML commented on PR #38636:
URL: https://github.com/apache/shardingsphere/pull/38636#issuecomment-4277513025

   
   1. Decision block
   Merge Verdict: Mergeable
   Reviewed Scope
   PR diff latest head aeb7ce2b5f821ef2f06e9d37143609b4d07d20d9
   pom.xml
   pom.xml
   Related startup-chain verification: start.sh, Dockerfile, ShardingSphereJdbcAgentContainer.java
   Not Reviewed Scope
   No deep review of unchanged implementation details in other modules (parser/kernel/proxy runtime).
   Need Expert Review
   No (this PR only refactors test packaging and e2e resource assembly paths).
   2. Basis
   Root-cause repair chain is complete: the PR switches JDBC fixture packaging from “multi-jar + copy-dependencies” to shade output, and updates engine copy targets to lib/agent-test-app-*.jar, while explicitly restoring start.sh copy to remove coupling to the old target/app layout.
   Adversarial risk scan (latest head) passed:
   Cross-path regression: changes are limited to e2e.env.jdbc profile and do not affect proxy profile (non-target path unchanged).
   Disabled/config-off path: when e2e.env.jdbc is not enabled, these copy executions do not run, so default build behavior is unchanged.
   Original symptom coverage: CI agent JDBC scenarios E2E - Agent with MySQL (jdbc, logging/file/metrics/tracing) are all success.
   Semantic compatibility: start.sh still uses lib/* classpath, and fat-jar under lib is loadable; config.yaml is still provided via container resource mapping to conf/config.yaml, not expected inside the jar (consistent with existing design).
   3. Pre-merge checks
   GitHub checks (head commit): no failure conclusions found; 74 check-runs are success or expected skipped.
   Local verification commands:
   ./mvnw -pl test/e2e/agent/fixture/jdbc-fixture -am -Prelease -DskipTests -Dspotless.skip=true -Dcheckstyle.skip=true package -> exit 0
   ./mvnw -pl test/e2e/agent/fixture/jdbc-fixture,test/e2e/agent/engine -am -Prelease,e2e.env.jdbc -DskipTests -Dspotless.skip=true -Dcheckstyle.skip=true package -> exit 1 (sandbox Docker socket permission on 127.0.0.1:2375; before failure, new copy logic was verified as executed).
   Sources
   
   PR: https://github.com/apache/shardingsphere/pull/38636
   PR metadata API: https://api.github.com/repos/apache/shardingsphere/pulls/38636
   Files API: https://api.github.com/repos/apache/shardingsphere/pulls/38636/files
   Checks API: https://api.github.com/repos/apache/shardingsphere/commits/aeb7ce2b5f821ef2f06e9d37143609b4d07d20d9/check-runs?per_page=100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor agent e2e test pom for jdbc [shardingsphere]

["RaigorJiang (via GitHub)" <gi...@apache.org>]

RaigorJiang merged PR #38636:
URL: https://github.com/apache/shardingsphere/pull/38636


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org