You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jesús Camacho Rodríguez <jc...@hortonworks.com> on 2016/06/27 16:38:19 UTC
Review Request 49271: HIVE-13803
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49271/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-13803
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexUtil.java 87fc1b9be3456a19627e8f48b8298b7cbb82a7a5
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java 9cec6cae5aab32f272005eb6ce42e0287078b543
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java fb43e7d5fef4764240aa4448af84d23fcc6b06fc
ql/src/test/results/clientpositive/constprog3.q.out cb440dca70e1cc9930ec12e6abff6b2c513494cf
ql/src/test/results/clientpositive/infer_join_preds.q.out 38baed37cfe144b18a113309fedac29d35858a7e
ql/src/test/results/clientpositive/mergejoin.q.out 8dd86deaa537b1ef15c8d97a65db9a846852ab3a
ql/src/test/results/clientpositive/subquery_multiinsert.q.out fd355470ac0244b2ad2c3077836b79e07c7a91f0
ql/src/test/results/clientpositive/tez/mergejoin.q.out 1f70c46716f1d7565e55b769a4bc4d3c69c1d74d
Diff: https://reviews.apache.org/r/49271/diff/
Testing
-------
Thanks,
Jes�s Camacho Rodr�guez
Re: Review Request 49271: HIVE-13803
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49271/#review139594
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java (line 201)
<https://reviews.apache.org/r/49271/#comment204845>
This is different wrt Calcite version. We need to check that the columns are not empty, otherwise we might end up pushing up predicates through the Aggregate that we should not.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java (line 386)
<https://reviews.apache.org/r/49271/#comment204846>
This is the difference wrt Calcite. We compute fields that do not reference any column, and we push them to the join inputs if it is an inner join.
- Jes�s Camacho Rodr�guez
On June 27, 2016, 4:39 p.m., Jes�s Camacho Rodr�guez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49271/
> -----------------------------------------------------------
>
> (Updated June 27, 2016, 4:39 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Bugs: HIVE-13803
> https://issues.apache.org/jira/browse/HIVE-13803
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-13803
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexUtil.java 87fc1b9be3456a19627e8f48b8298b7cbb82a7a5
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java 9cec6cae5aab32f272005eb6ce42e0287078b543
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java fb43e7d5fef4764240aa4448af84d23fcc6b06fc
> ql/src/test/results/clientpositive/constprog3.q.out cb440dca70e1cc9930ec12e6abff6b2c513494cf
> ql/src/test/results/clientpositive/infer_join_preds.q.out 38baed37cfe144b18a113309fedac29d35858a7e
> ql/src/test/results/clientpositive/mergejoin.q.out 8dd86deaa537b1ef15c8d97a65db9a846852ab3a
> ql/src/test/results/clientpositive/subquery_multiinsert.q.out fd355470ac0244b2ad2c3077836b79e07c7a91f0
> ql/src/test/results/clientpositive/tez/mergejoin.q.out 1f70c46716f1d7565e55b769a4bc4d3c69c1d74d
>
> Diff: https://reviews.apache.org/r/49271/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jes�s Camacho Rodr�guez
>
>
Re: Review Request 49271: HIVE-13803
Posted by Jesús Camacho Rodríguez <jc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49271/
-----------------------------------------------------------
(Updated June 27, 2016, 4:39 p.m.)
Review request for hive and Ashutosh Chauhan.
Bugs: HIVE-13803
https://issues.apache.org/jira/browse/HIVE-13803
Repository: hive-git
Description
-------
HIVE-13803
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexUtil.java 87fc1b9be3456a19627e8f48b8298b7cbb82a7a5
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/stats/HiveRelMdPredicates.java 9cec6cae5aab32f272005eb6ce42e0287078b543
ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java fb43e7d5fef4764240aa4448af84d23fcc6b06fc
ql/src/test/results/clientpositive/constprog3.q.out cb440dca70e1cc9930ec12e6abff6b2c513494cf
ql/src/test/results/clientpositive/infer_join_preds.q.out 38baed37cfe144b18a113309fedac29d35858a7e
ql/src/test/results/clientpositive/mergejoin.q.out 8dd86deaa537b1ef15c8d97a65db9a846852ab3a
ql/src/test/results/clientpositive/subquery_multiinsert.q.out fd355470ac0244b2ad2c3077836b79e07c7a91f0
ql/src/test/results/clientpositive/tez/mergejoin.q.out 1f70c46716f1d7565e55b769a4bc4d3c69c1d74d
Diff: https://reviews.apache.org/r/49271/diff/
Testing
-------
Thanks,
Jes�s Camacho Rodr�guez