[GitHub] [linkis] peacewong commented on a diff in pull request #4326: [Feature][LinkisManager] Add task fixed engine label

["peacewong (via GitHub)" <gi...@apache.org>]

peacewong commented on code in PR #4326:
URL: https://github.com/apache/linkis/pull/4326#discussion_r1127733169


##########
linkis-engineconn-plugins/hive/src/main/scala/org/apache/linkis/engineplugin/hive/executor/HiveEngineConnExecutor.scala:
##########
@@ -414,6 +416,7 @@ class HiveEngineConnExecutor(
     singleSqlProgressMap.clear()
     Utils.tryAndWarnMsg(sessionState.close())("close session failed")
     super.close()
+    killTask("close")

Review Comment:
   Maybe can remove it, for the super method has invoked the kill task. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org