You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "Lambert-Rao (via GitHub)" <gi...@apache.org> on 2024/02/07 08:06:28 UTC
[PR] [ISSUE #30] modify mappers and add test [eventmesh-dashboard]
Lambert-Rao opened a new pull request, #31:
URL: https://github.com/apache/eventmesh-dashboard/pull/31
improved connection, connector, client, meta, health mappers and add their unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #30] modify mappers and add test [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #31:
URL: https://github.com/apache/eventmesh-dashboard/pull/31#issuecomment-1951348321
Besides, you may change the database username and password to `root` and `password` in config to run unit tests after https://github.com/apache/eventmesh-dashboard/issues/32 has accomplished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #30] modify mappers and add test [eventmesh-dashboard]
Posted by "Lambert-Rao (via GitHub)" <gi...@apache.org>.
Lambert-Rao commented on PR #31:
URL: https://github.com/apache/eventmesh-dashboard/pull/31#issuecomment-1951816582
> Besides, you may change the database name, username and password to `EVENTMESH_DASHBOARD`, `root` and `password` in config to run unit tests after #32 has accomplished.
@Pil0tXia
I have used `eventmesh-dashboard-test` as the test database name, is there a specific reason for using `EVENTMESH_DASHBOARD`? If not, I would edit your ci file.
Also, should the test database host be `localhost`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #30] modify mappers and add test [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #31:
URL: https://github.com/apache/eventmesh-dashboard/pull/31#issuecomment-1938932340
@Lambert-Rao
You may pull mysql docker image in Github workflow to run unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #30] modify mappers and add test [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #31:
URL: https://github.com/apache/eventmesh-dashboard/pull/31#issuecomment-1932842602
plz check ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #30] modify mappers and add test [eventmesh-dashboard]
Posted by "Lambert-Rao (via GitHub)" <gi...@apache.org>.
Lambert-Rao commented on PR #31:
URL: https://github.com/apache/eventmesh-dashboard/pull/31#issuecomment-1935023032
CI failed for database test, I have tested them successfully locally, if unit tests are still unavaiiable, I will remove them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #30] modify mappers and add test [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #31:
URL: https://github.com/apache/eventmesh-dashboard/pull/31#issuecomment-1951931193
Using `-` in the database name is not a best practice as it is recommended to use `_`.
You can try `localhost` first and see if the application can establish a connection with the container. If it fails, we need to set a `MYSQL_ADDR` environment variable and use `127.0.0.1` as the MySQL host in GitHub Actions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #30] modify mappers and add test [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia closed pull request #31: [ISSUE #30] modify mappers and add test
URL: https://github.com/apache/eventmesh-dashboard/pull/31
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #30] modify mappers and add test [eventmesh-dashboard]
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #31:
URL: https://github.com/apache/eventmesh-dashboard/pull/31#issuecomment-1951347972
Please submit the PR to `dev` branch instead of `develop` branch.
I should have changed this PR's merge destination to `dev` before deleting `develop` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org