You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Conor MacNeill <co...@cortexebusiness.com.au> on 2001/07/06 14:06:16 UTC
Re: UPDATE: [PATCH] add "inheritAll" attribute to task (Ant.java), defaults to true
Craeg,
From: "Craeg K Strong" <cs...@arielpartners.com>
> > Hello:
> >
> > The enclosed patch adds a new "inheritAll" attribute to the <ant> task.
> > The attribute defaults to "true" which preserves current behavior.
> > If set to "false," the only properties passed along to the sub-build
> > are userProperties (i.e., properties specified on the command line) and
> > properties specified within the actual <ant> call.
> >
> > Please see my earlier message for more background information:
> > http://marc.theaimsgroup.com/?l=ant-dev&m=99323191628596&w=2
> >
> > Thanks!
> >
> > --Craeg
> >
I have committed that. For future reference, please be careful with tabs.
We prefer spaces to tabs and if you do use tabs, please set tabs at 8. I
think your's were set to 3.
Cheers
Conor
Re: UPDATE: [PATCH] add "inheritAll" attribute to task (Ant.java), defaults to true
Posted by Craeg K Strong <cs...@arielpartners.com>.
Conor MacNeill wrote:
>Oh, I forgot to add - can you supply a documentation update as well.
>
Attached please find the documentation patch to
docs/manual/CoreTasks/ant.html
Let me know if it is not clear enough...
Thanks,
--Craeg
--
Craeg K. Strong | www.arielpartners.com
Ariel Partners LLC | cstrong@arielpartners.com
85 River Street, Ste. 3A | Fax: (781) 647-9690
Waltham, MA 02453 | Voice: (781) 647-2425
Re: UPDATE: [PATCH] add "inheritAll" attribute to task (Ant.java), defaults to true
Posted by Conor MacNeill <co...@cortexebusiness.com.au>.
> Craeg,
>
>
> I have committed that. For future reference, please be careful with tabs.
> We prefer spaces to tabs and if you do use tabs, please set tabs at 8. I
> think your's were set to 3.
>
Oh, I forgot to add - can you supply a documentation update as well.
Thanks
Conor
Re: UPDATE: [PATCH] add "inheritAll" attribute to task (Ant.java), defaults to true
Posted by Craeg K Strong <cs...@arielpartners.com>.
Conor MacNeill wrote:
>Craeg,
>
>From: "Craeg K Strong" <cs...@arielpartners.com>
>
>>>Hello:
>>>
>>>The enclosed patch adds a new "inheritAll" attribute to the <ant> task.
>>>The attribute defaults to "true" which preserves current behavior.
>>>If set to "false," the only properties passed along to the sub-build
>>>are userProperties (i.e., properties specified on the command line) and
>>>properties specified within the actual <ant> call.
>>>
>>>Please see my earlier message for more background information:
>>>http://marc.theaimsgroup.com/?l=ant-dev&m=99323191628596&w=2
>>>
>>>Thanks!
>>>
>>>--Craeg
>>>
>
>I have committed that. For future reference, please be careful with tabs.
>We prefer spaces to tabs and if you do use tabs, please set tabs at 8. I
>think your's were set to 3.
>
>Cheers
>Conor
>
>
No problem-- I will adjust my emacs settings. Thanks for letting me
know :-)
BTW-- what did you think about the <dependset> idea?
I have prepared an "ant manual" HTML page for it; should I send it along?
-- Craeg
--
Craeg K. Strong | www.arielpartners.com
Ariel Partners LLC | cstrong@arielpartners.com
85 River Street, Ste. 3A | Fax: (781) 647-9690
Waltham, MA 02453 | Voice: (781) 647-2425
RE: UPDATE: [PATCH] add "inheritAll" attribute to task (Ant.java), defaults to true
Posted by Jérôme Lacoste <je...@smartcardsystem.com>.
> I have committed that. For future reference, please be careful with tabs.
> We prefer spaces to tabs and if you do use tabs, please set tabs at 8. I
> think your's were set to 3.
why not run a checkstyle task on the code to detect these problems?
http://sourceforge.net/projects/checkstyle
It integrates well with Ant. That would perhaps be nice for Ant 2. Enforce
coding convention and documentation.
Jerome