[GitHub] [pinot] richardstartin commented on pull request #7431: adding in source/target version

[GitBox <gi...@apache.org>]

richardstartin commented on pull request #7431:
URL: https://github.com/apache/pinot/pull/7431#issuecomment-919362129


   Note that Java 8 compatibility does not require building with JDK8, it requires producing classfiles with version 52.0 linked against the JDK8 bootclasspath, so that the classes can be loaded on JDK8. This can be done with later versions of javac by setting the `release` flag. The advantage of using later versions of javac is that you can compile code to be packaged in Multi-Release jars, so you could, say, use foreign memory access on JDK17 but use `sun.misc.Unsafe` on JDK8. The requirement to _build with JDK8_ precludes this, or at the very least makes it much harder than it needs to be. I will create an issue to track this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org