You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/02/03 23:33:38 UTC
[GitHub] [druid] gianm opened a new pull request #12230: Harmonize implementations of "visit" for Exprs from ExprMacros.
gianm opened a new pull request #12230:
URL: https://github.com/apache/druid/pull/12230
Many of them had bugs where they would not visit all of the original
arguments. I don't think this has user-visible consequences right now,
but it's possible it would in a future world where "visit" is used
for more stuff than it is today.
So, this patch all updates all implementations to a more consistent
style that emphasizes reapplying the macro to the shuttled args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm merged pull request #12230: Harmonize implementations of "visit" for Exprs from ExprMacros.
Posted by GitBox <gi...@apache.org>.
gianm merged pull request #12230:
URL: https://github.com/apache/druid/pull/12230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #12230: Harmonize implementations of "visit" for Exprs from ExprMacros.
Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #12230:
URL: https://github.com/apache/druid/pull/12230#issuecomment-1029570976
> 👍
>
> Do you mind also updating [`FunctionExpr`](https://github.com/apache/druid/blob/master/core/src/main/java/org/apache/druid/math/expr/FunctionalExpr.java#L207) and [`ApplyFunctionExpr`](https://github.com/apache/druid/blob/master/core/src/main/java/org/apache/druid/math/expr/FunctionalExpr.java#L337) to use `visitAll`?
Sure, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org