[jira] [Commented] (CASSANDRA-17998) Mutation Serialization Caching

["Josh McKenzie (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643971#comment-17643971 ] 

Josh McKenzie commented on CASSANDRA-17998:
-------------------------------------------

Couple of trivial spelling errors on the follow up commits and we lost one of our new unit tests during the mix. With those + a clean run of CI I'm a +1.

Great work!

> Mutation Serialization Caching
> ------------------------------
>
>                 Key: CASSANDRA-17998
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17998
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Messaging/Internode
>            Reporter: T Jake Luciani
>            Assignee: T Jake Luciani
>            Priority: Normal
>             Fix For: 4.x
>
>
> A performance change that adds mutation serialization caching to avoid re-serializing the mutation for commitlog and nodes twice. 
>  * Cached serialization for storage proxy and local commitlog
>  * Cached deserialization for messaging service and local commitlog
> This yields a non trivial perf gain (~7-10%) and latency drop (median)
> [https://tjake.github.io/other/cached-mutations-report.html]
>  
> The cached buffer is stored by MessagingService version to avoid being used by differing nodes during upgrades.
> Also, It avoids caching mutations larger than a threshold to avoid GC issues. 
>  
> GH PR: https://github.com/apache/cassandra/pull/1954
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org