Re: [PR] SCIM attributes according to spec [directory-scimple]

["bdemers (via GitHub)" <gi...@apache.org>]

bdemers commented on code in PR #481:
URL: https://github.com/apache/directory-scimple/pull/481#discussion_r1439543083


##########
scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/resources/ScimResource.java:
##########
@@ -62,11 +63,11 @@ public abstract class ScimResource extends BaseResource<ScimResource> implements
 
   @XmlElement
   @Size(min = 1)
-  @ScimAttribute(required = true, returned = Returned.ALWAYS, description = "A unique identifier for a SCIM resource as defined by the service provider.")
+  @ScimAttribute(required = true, returned = Returned.ALWAYS, mutability = Schema.Attribute.Mutability.READ_ONLY, uniqueness = Schema.Attribute.Uniqueness.SERVER, description = "A unique identifier for a SCIM resource as defined by the service provider.")
   String id;
 
   @XmlElement
-  @ScimAttribute
+  @ScimAttribute(returned = Returned.DEFAULT, caseExact = true, mutability = Schema.Attribute.Mutability.READ_WRITE)

Review Comment:
   nit: The `returned` attribute could be removed as it's the default value



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org