You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@parquet.apache.org by "RussellSpitzer (via GitHub)" <gi...@apache.org> on 2026/09/22 21:18:35 UTC

[PR] Release: complete the Nexus secret rename and harden cancel/publish [parquet-java]

RussellSpitzer opened a new pull request, #3814:
URL: https://github.com/apache/parquet-java/pull/3814

   
   <!--
   Thanks for opening a pull request!
   
   If you're new to Parquet-Java, information on how to contribute can be found here: https://parquet.apache.org/docs/contribution-guidelines/contributing
   
   Please open a GitHub issue for this pull request: https://github.com/apache/parquet-java/issues/new/choose
   and format pull request title as below:
   
       GH-${GITHUB_ISSUE_ID}: ${SUMMARY}
   
   or simply use the title below if it is a minor issue:
   
       MINOR: ${SUMMARY}
   
   -->
   
   ### Rationale for this change
   
   While we fixed the URLs for Nexus checking in the prepare script, we did not also fix it in the Cancel and publish script. 
   
   ### What changes are included in this PR?
   
   Urls are fixed and a safeguard is included to make sure that if our required secrets are not set, we fail fast. Also do the same Tag reordering thing we also fixed in prepare which moves the GitHub tagging to the end so that a failed publish doesn't leave behind a git tag.
   
   ### Are these changes tested?
   
   Local Bats runs.
   
   ### Are there any user-facing changes?
   
   No
   
   <!-- Please uncomment the line below and replace ${GITHUB_ISSUE_ID} with the actual Github issue id. -->
   <!-- Closes #${GITHUB_ISSUE_ID} -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] Release: complete the Nexus secret rename and harden cancel/publish [parquet-java]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko merged PR #3814:
URL: https://github.com/apache/parquet-java/pull/3814


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org


Re: [PR] Release: complete the Nexus secret rename and harden cancel/publish [parquet-java]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #3814:
URL: https://github.com/apache/parquet-java/pull/3814#discussion_r4079765814


##########
.github/workflows/release-cancel-rc.yml:
##########
@@ -70,8 +70,8 @@ jobs:
       - name: Cancel Release Candidate
         env:
           DRY_RUN: ${{ inputs.dry_run && '1' || '0' }}
-          NEXUS_USERNAME: ${{ secrets.PARQUET_NEXUS_USER }}
-          NEXUS_PASSWORD: ${{ secrets.PARQUET_NEXUS_PASSWORD }}
+          NEXUS_USERNAME: ${{ secrets.NEXUS_STAGE_DEPLOYER_USER }}

Review Comment:
   This is the last one: https://github.com/search?q=repo%3Aapache%2Fparquet-java+PARQUET_NEXUS_USER&type=code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org