You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/10/01 09:57:34 UTC

[GitHub] [ratis] tisonkun opened a new pull request, #753: RATIS-1713. Fix TakeSnapshotCommand's usage info

tisonkun opened a new pull request, #753:
URL: https://github.com/apache/ratis/pull/753

   Trivial change.
   
   https://issues.apache.org/jira/browse/RATIS-1713


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] tisonkun commented on a diff in pull request #753: RATIS-1713. Fix TakeSnapshotCommand's usage info

Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #753:
URL: https://github.com/apache/ratis/pull/753#discussion_r985084169


##########
ratis-shell/src/main/java/org/apache/ratis/shell/cli/sh/snapshot/TakeSnapshotCommand.java:
##########
@@ -79,7 +79,7 @@ public String getUsage() {
             + " [-%s <RAFT_GROUP_ID>]"
             + " [-%s <timeoutInMs>]"
             + " [-%s <raftPeerId>]",
-        getCommandName(), PEER_OPTION_NAME, GROUPID_OPTION_NAME, TAKE_SNAPSHOT_TIMEOUT_OPTION_NAME);
+        getCommandName(), PEER_OPTION_NAME, GROUPID_OPTION_NAME, TAKE_SNAPSHOT_TIMEOUT_OPTION_NAME, PEER_ID_OPTION_NAME);

Review Comment:
   ```suggestion
           getCommandName(),
           PEER_OPTION_NAME,
           GROUPID_OPTION_NAME,
           TAKE_SNAPSHOT_TIMEOUT_OPTION_NAME,
           PEER_ID_OPTION_NAME);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo merged pull request #753: RATIS-1713. Fix TakeSnapshotCommand's usage info

Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #753:
URL: https://github.com/apache/ratis/pull/753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org