You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mattisonchao (via GitHub)" <gi...@apache.org> on 2023/03/21 13:48:23 UTC
[GitHub] [pulsar] mattisonchao commented on a diff in pull request #19875: [fix][broker] Fix NPE when update topic policy.
mattisonchao commented on code in PR #19875:
URL: https://github.com/apache/pulsar/pull/19875#discussion_r1143406641
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java:
##########
@@ -240,7 +240,9 @@ protected void updateTopicPolicy(TopicPolicies data) {
topicPolicies.getDispatchRate().updateTopicValue(DispatchRateImpl.normalize(data.getDispatchRate()));
topicPolicies.getSchemaValidationEnforced().updateTopicValue(data.getSchemaValidationEnforced());
topicPolicies.getEntryFilters().updateTopicValue(data.getEntryFilters());
- this.subscriptionPolicies = data.getSubscriptionPolicies();
+ if (data.getSubscriptionPolicies() != null) {
Review Comment:
I am wondering why `subscriptionPolicies` can be null. Is it passed by `TopicPoliceis`? Because I saw many places invoke `TopicPoliceis#getSubscriptionPolicies.get(xxx)` without an NPE check.
Should we consider avoiding this value as null?
Please correct me if I got something wrong.
/cc @Technoboy- @poorbarcode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org