You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "prashantwason (via GitHub)" <gi...@apache.org> on 2023/04/28 17:01:53 UTC

[GitHub] [hudi] prashantwason opened a new pull request, #8599: [MINOR] Ensure metrics prefix does not contain any dot.

prashantwason opened a new pull request, #8599:
URL: https://github.com/apache/hudi/pull/8599

   [MINOR] Ensure metrics prefix does not contain any dot.
   
   ### Change Logs
   
   Replace all dots with underscore in metric prefix.
   
   ### Impact
   
   Corrects the publishing of metric with correct metric prefix.
   
   ### Risk level (write none, low medium or high below)
   
   None
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #8599: [MINOR] Ensure metrics prefix does not contain any dot.

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #8599:
URL: https://github.com/apache/hudi/pull/8599


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] prashantwason commented on a diff in pull request #8599: [MINOR] Ensure metrics prefix does not contain any dot.

Posted by "prashantwason (via GitHub)" <gi...@apache.org>.
prashantwason commented on code in PR #8599:
URL: https://github.com/apache/hudi/pull/8599#discussion_r1203396182


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2175,7 +2175,8 @@ public boolean getPushGatewayRandomJobNameSuffix() {
   }
 
   public String getMetricReporterMetricsNamePrefix() {
-    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX);
+    // Metrics prefixes should not have a dot as this is usually a separator
+    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX).replaceAll("\\.", "_");

Review Comment:
   @rmahindra123 @harsh1231 Do you have any thoughts on this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8599: [MINOR] Ensure metrics prefix does not contain any dot.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8599:
URL: https://github.com/apache/hudi/pull/8599#issuecomment-1527894279

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d3139b0dbc36926f95258498006a38b804e94c33",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16744",
       "triggerID" : "d3139b0dbc36926f95258498006a38b804e94c33",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3139b0dbc36926f95258498006a38b804e94c33 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16744) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8599: [MINOR] Ensure metrics prefix does not contain any dot.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8599:
URL: https://github.com/apache/hudi/pull/8599#issuecomment-1527886176

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d3139b0dbc36926f95258498006a38b804e94c33",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d3139b0dbc36926f95258498006a38b804e94c33",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3139b0dbc36926f95258498006a38b804e94c33 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8599: [MINOR] Ensure metrics prefix does not contain any dot.

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8599:
URL: https://github.com/apache/hudi/pull/8599#issuecomment-1528545607

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d3139b0dbc36926f95258498006a38b804e94c33",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16744",
       "triggerID" : "d3139b0dbc36926f95258498006a38b804e94c33",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d3139b0dbc36926f95258498006a38b804e94c33 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16744) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope commented on a diff in pull request #8599: [MINOR] Ensure metrics prefix does not contain any dot.

Posted by "codope (via GitHub)" <gi...@apache.org>.
codope commented on code in PR #8599:
URL: https://github.com/apache/hudi/pull/8599#discussion_r1207652532


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2175,7 +2175,8 @@ public boolean getPushGatewayRandomJobNameSuffix() {
   }
 
   public String getMetricReporterMetricsNamePrefix() {
-    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX);
+    // Metrics prefixes should not have a dot as this is usually a separator
+    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX).replaceAll("\\.", "_");

Review Comment:
   I think it should be ok as long as well call out the change. Most metrics systems are append-only, so there will be two metrics for the same purpose for some time. Downstream consumers will have to make changes in the query to pick up the newer format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on a diff in pull request #8599: [MINOR] Ensure metrics prefix does not contain any dot.

Posted by "nsivabalan (via GitHub)" <gi...@apache.org>.
nsivabalan commented on code in PR #8599:
URL: https://github.com/apache/hudi/pull/8599#discussion_r1185542046


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2175,7 +2175,8 @@ public boolean getPushGatewayRandomJobNameSuffix() {
   }
 
   public String getMetricReporterMetricsNamePrefix() {
-    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX);
+    // Metrics prefixes should not have a dot as this is usually a separator
+    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX).replaceAll("\\.", "_");

Review Comment:
   I see why we do this. If the metrics prefix has "." (dots), it might cause issues w/ dashbaords. So, may be not a bad idea. but it might break someone who was using it so far (by mistake)
   @rmahindra123 @harsh1231 : do you folks have any thoughts here. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 commented on a diff in pull request #8599: [MINOR] Ensure metrics prefix does not contain any dot.

Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8599:
URL: https://github.com/apache/hudi/pull/8599#discussion_r1181158282


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -2175,7 +2175,8 @@ public boolean getPushGatewayRandomJobNameSuffix() {
   }
 
   public String getMetricReporterMetricsNamePrefix() {
-    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX);
+    // Metrics prefixes should not have a dot as this is usually a separator
+    return getStringOrDefault(HoodieMetricsConfig.METRICS_REPORTER_PREFIX).replaceAll("\\.", "_");

Review Comment:
   Can we just report the invalid format and throws exception ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org