You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/01 19:40:41 UTC

[GitHub] [spark] maryannxue commented on issue #24978: [SPARK-28177][SQL] Adjust post shuffle partition number in adaptive execution

maryannxue commented on issue #24978: [SPARK-28177][SQL] Adjust post shuffle partition number in adaptive execution
URL: https://github.com/apache/spark/pull/24978#issuecomment-507397676
 
 
   Some general comments:
   1. Can we remove the config renaming from this PR as @hvanhovell requested? We can have a separate PR to address this. And also I can file a follow-up PR to add an independent conf for SMJ -> BHJ.
   2. Can we add end2end tests where SMJ->BHJ and reduce-shuffle-num happen at the same time?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org