You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@xerces.apache.org by Michael Mason <mg...@decisionsoft.com> on 2000/01/04 12:37:47 UTC
Patch for IconvTransService
It seems in the recent update this wasn't quite changed all the way
through, and was failing to build under Linux with -m inmem -t native.
This is just a typo fix:
Index: IconvTransService.cpp
===================================================================
RCS file:
/home/cvspublic/xml-xerces/c/src/util/Transcoders/Iconv/IconvTransService.cpp,v
retrieving revision 1.6
diff -u -u -r1.6 IconvTransService.cpp
--- IconvTransService.cpp 1999/12/18 00:22:32 1.6
+++ IconvTransService.cpp 2000/01/04 11:09:12
@@ -188,7 +188,7 @@
}
-XMLTranscoder* IconvTransService::makeNewLCPTranscoder()
+XMLLCPTranscoder* IconvTransService::makeNewLCPTranscoder()
{
// Just allocate a new transcoder of our type
return new IconvLCPTranscoder;
Index: IconvTransService.hpp
===================================================================
RCS file:
/home/cvspublic/xml-xerces/c/src/util/Transcoders/Iconv/IconvTransService.hpp,v
retrieving revision 1.2
diff -u -u -r1.2 IconvTransService.hpp
--- IconvTransService.hpp 1999/12/18 00:22:32 1.2
+++ IconvTransService.hpp 2000/01/04 11:09:13
@@ -100,7 +100,7 @@
virtual bool isSpace(const XMLCh toCheck) const;
- virtual XMLTranscoder* makeNewLCPTranscoder();
+ virtual XMLLCPTranscoder* makeNewLCPTranscoder();
protected :
@@ -126,7 +126,7 @@
-class XMLUTIL_EXPORT IconvTranscoder : public XMLTranscoder
+class XMLUTIL_EXPORT IconvTranscoder : public XMLLCPTranscoder
{
public :
//
-----------------------------------------------------------------------
@@ -172,8 +172,8 @@
//
-----------------------------------------------------------------------
// Constructors and Destructor
//
-----------------------------------------------------------------------
- IconvTranscoder();
- ~IconvTranscoder();
+ IconvLCPTranscoder();
+ ~IconvLCPTranscoder();
//
-----------------------------------------------------------------------
(The long lines are probably going to break here...) The above changes
get IconvTransService.o to compile, but then there's a problem with
Linux/LinuxPlatformUtils.cpp:
Linux/LinuxPlatformUtils.cpp: In function `static class XMLTransService
* XMLPlatformUtils::makeTransService()':
Linux/LinuxPlatformUtils.cpp:363: cannot allocate an object of type
`IconvTransService'
Linux/LinuxPlatformUtils.cpp:363: since the following virtual
functions are abstract:
Linux/LinuxPlatformUtils.cpp:363: void
XMLTransService::upperCase(short unsigned int *) const
And indeed, the parent class XMLTransService specifies upperCase() but
IconvTransService doesn't implement it. I haven't delved into how to
uppercase properly, since I'm guessing this problem is caused by similar
typos to the above.
Anyone got a copy that compiles? Mine's a clean checkout as of today
(4th Jan).
And Seasons Greetings gang!
Cheers,
Mike.
--
Mike Mason, Software Engineer
XML Script Development Team Office: 44-1865-203192
http://www.xmlscript.org/ Mobile: 44-7050-288923
Re: Patch for IconvTransService
Posted by Jonathan McDowell <no...@earth.li>.
On Tue, Jan 04, 2000 at 11:37:47AM +0000, Michael Mason wrote:
> It seems in the recent update this wasn't quite changed all the way
> through, and was failing to build under Linux with -m inmem -t native.
> This is just a typo fix:
[snip typo fix and LinuxPlatformUtils.cpp errors]
> Anyone got a copy that compiles? Mine's a clean checkout as of today
> (4th Jan).
FWIW, I'm seeing the same problems with my FreeBSD port - not surprising,
as my FreeBSDPlatformUtils.cpp is based on LinuxPlatformUtils.cpp.
Still, from my point of view it's good to know the problem's not a
porting issue. ;)
J.
--
] http://www.earth.li/~noodles/ [] "Remember - if all you have is an [
] PGP/GPG Key @ keys.pgp.net or [] axe, every problem looks like hours [
] finger noodles@ox.compsoc.net [] of fun." -- Frossie, asr. [
] PGP: 4DC4E7FD / GPG: 5B430367 [] [