[GitHub] libcloud pull request #951: Driver Implementation for the cloudscale.ch API

[davidhalter <gi...@git.apache.org>]

GitHub user davidhalter opened a pull request:

    https://github.com/apache/libcloud/pull/951

    Driver Implementation for the cloudscale.ch API

    ## A Driver Implementation for the cloudscale.ch API
    
    ### Description
    
    It's pretty simple, I have added a new driver for the cloudscale.ch API (https://www.cloudscale.ch/en/api/v1). The cloudscale.ch API is very simple and doesn't offer a lot more than what libcloud's `compute` module by default offers. I have also tried to communicate this in the documentation.
    
    ### Status
    
    The code feels mostly like it's done and ready for review. It passes 2.7, 3.3, 3.4, 3.5, lint and pylint. I have looked at other drivers in libcloud and tried to copy how they document/test. I haven't added tons of tests, but comparably to others the driver is also smaller and therefore the amount of tests seem to align.
    
    Just let me know what you think. Happy to improve my code!
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x] Documentation
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    - [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
    
    I still have to sign the ICLA. I will do that ASAP. I just wanted to get some feedback from you guys on this piece of code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloudscale-ch/libcloud cloudscale

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/951.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #951
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #951: Driver Implementation for the cloudscale.ch API

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/951


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---