You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@asterixdb.apache.org by mh...@apache.org on 2018/12/09 22:57:55 UTC
[2/6] asterixdb git commit: [NO ISSUE][OTH] Pass Request Parameters
To Extensions
[NO ISSUE][OTH] Pass Request Parameters To Extensions
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Pass request parameters to create/drop dataverse
statements to allow extensions to use optional
request parameters.
Change-Id: I284560ea3a7e3d1b36d73a8cfcdc85bf7b5a7f4e
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3044
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <mh...@apache.org>
Reviewed-by: Till Westmann <ti...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/asterixdb/repo
Commit: http://git-wip-us.apache.org/repos/asf/asterixdb/commit/d7936324
Tree: http://git-wip-us.apache.org/repos/asf/asterixdb/tree/d7936324
Diff: http://git-wip-us.apache.org/repos/asf/asterixdb/diff/d7936324
Branch: refs/heads/master
Commit: d79363249d8d7106b3bbe352ead18eb01fe9b973
Parents: 821c072
Author: Murtadha Hubail <mh...@apache.org>
Authored: Wed Nov 28 17:07:46 2018 +0300
Committer: Murtadha Hubail <mh...@apache.org>
Committed: Fri Nov 30 14:39:38 2018 -0800
----------------------------------------------------------------------
.../org/apache/asterix/app/translator/QueryTranslator.java | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/asterixdb/blob/d7936324/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
----------------------------------------------------------------------
diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
index 8e86b9c..f619ab6 100644
--- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
+++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java
@@ -309,7 +309,7 @@ public class QueryTranslator extends AbstractLangTranslator implements IStatemen
activeDataverse = handleUseDataverseStatement(metadataProvider, stmt);
break;
case CREATE_DATAVERSE:
- handleCreateDataverseStatement(metadataProvider, stmt);
+ handleCreateDataverseStatement(metadataProvider, stmt, requestParameters);
break;
case DATASET_DECL:
handleCreateDatasetStatement(metadataProvider, stmt, hcc, requestParameters);
@@ -324,7 +324,7 @@ public class QueryTranslator extends AbstractLangTranslator implements IStatemen
handleCreateNodeGroupStatement(metadataProvider, stmt);
break;
case DATAVERSE_DROP:
- handleDataverseDropStatement(metadataProvider, stmt, hcc);
+ handleDataverseDropStatement(metadataProvider, stmt, hcc, requestParameters);
break;
case DATASET_DROP:
handleDatasetDropStatement(metadataProvider, stmt, hcc, requestParameters);
@@ -466,7 +466,8 @@ public class QueryTranslator extends AbstractLangTranslator implements IStatemen
}
}
- protected void handleCreateDataverseStatement(MetadataProvider metadataProvider, Statement stmt) throws Exception {
+ protected void handleCreateDataverseStatement(MetadataProvider metadataProvider, Statement stmt,
+ IRequestParameters requestParameters) throws Exception {
CreateDataverseStatement stmtCreateDataverse = (CreateDataverseStatement) stmt;
String dvName = stmtCreateDataverse.getDataverseName().getValue();
MetadataTransactionContext mdTxnCtx = MetadataManager.INSTANCE.beginTransaction();
@@ -1227,7 +1228,7 @@ public class QueryTranslator extends AbstractLangTranslator implements IStatemen
}
protected void handleDataverseDropStatement(MetadataProvider metadataProvider, Statement stmt,
- IHyracksClientConnection hcc) throws Exception {
+ IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception {
DataverseDropStatement stmtDelete = (DataverseDropStatement) stmt;
SourceLocation sourceLoc = stmtDelete.getSourceLocation();
String dataverseName = stmtDelete.getDataverseName().getValue();