[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on a change in pull request #5163: [Improvement][LogServer] Thread pool parameter adjustment #5161

[GitBox <gi...@apache.org>]

CalvinKirs commented on a change in pull request #5163:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/5163#discussion_r602977201



##########
File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/log/LoggerRequestProcessor.java
##########
@@ -60,10 +62,10 @@
 
     private final Logger logger = LoggerFactory.getLogger(LoggerRequestProcessor.class);
 
-    private final ThreadPoolExecutor executor;
+    private final ExecutorService executor;
 
     public LoggerRequestProcessor() {
-        this.executor = new ThreadPoolExecutor(4, 4, 10, TimeUnit.SECONDS, new LinkedBlockingQueue<>(100));
+        this.executor = Executors.newFixedThreadPool(Constants.CPUS * 2);

Review comment:
       IO intensive is best set to 2*core+1




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org