You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/18 17:23:29 UTC

[GitHub] [superset] rea725 opened a new issue, #20117: Big Number with Trendline chart chops off bottom of trendline in latest master

rea725 opened a new issue, #20117:
URL: https://github.com/apache/superset/issues/20117

   ## Screenshot
   This is what we get in recent master.  Specifically, we're running this build: https://github.com/apache/superset/commit/ee178f47e1be56a90e5d7a549d5d47a5a805012f
   ![trendline-with-big-number-chopped](https://user-images.githubusercontent.com/276963/169102277-96421940-b65d-48f9-8ba2-ab31d4bafa9a.png)
   
   This is what we got in our old build 
   ![trendline-with-big-number-working-correctly](https://user-images.githubusercontent.com/276963/169102610-48d0da83-3e9e-42cb-8aa4-0f9a6d4309db.png)
   (~v1.2, commit 9c854ff):
   
   ## Description
   Latest builds are truncating the bottom few pixels of the Big Number with Trendline charts, when these charts are included in a dashboard.  When the chart is maximized, the issue is still presenting itself.  If the browser window is made to be over ~1000px tall, the issue goes away.  It looks as if a padding/border is covering up the bottom x% of the chart.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] stephenLYZ closed issue #20117: Big Number with Trendline chart chops off bottom of trendline in latest master

Posted by GitBox <gi...@apache.org>.
stephenLYZ closed issue #20117: Big Number with Trendline chart chops off bottom of trendline in latest master
URL: https://github.com/apache/superset/issues/20117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kamalkeshavani-aiinside commented on issue #20117: Big Number with Trendline chart chops off bottom of trendline in latest master

Posted by GitBox <gi...@apache.org>.
kamalkeshavani-aiinside commented on issue #20117:
URL: https://github.com/apache/superset/issues/20117#issuecomment-1143126373

   This issue is also present in release version 1.5.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] michael-s-molina commented on issue #20117: Big Number with Trendline chart chops off bottom of trendline in latest master

Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #20117:
URL: https://github.com/apache/superset/issues/20117#issuecomment-1149146557

   @stephenLYZ Any update on this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] stephenLYZ commented on issue #20117: Big Number with Trendline chart chops off bottom of trendline in latest master

Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on issue #20117:
URL: https://github.com/apache/superset/issues/20117#issuecomment-1150158513

   @michael-s-molina hi. I opened a [PR](https://github.com/apache/superset/pull/20315) to fix it.  Appreciate review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org