You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Laszlo Gaal (Code Review)" <ge...@cloudera.org> on 2023/05/03 15:14:36 UTC
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Laszlo Gaal has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19835
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Install libreadline-dev for toolchain builds on ARM hosts
This is required because ARM builds of the toolchain binaries are not
(yet) present in s3://native-toolchain, so ARM builds have to build the
toolchain locally, before being able to build Impala.
The toolchain's Python build failed before this patch, because it missed
the libreadline-dev package, which is needed for Python's readline support.
This patch adds it and its libncurses dependency.
Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
---
M bin/bootstrap_system.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/19835/1
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 2: Code-Review+1
Carry +1 from Michael
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 16:11:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19835
to look at the new patch set (#2).
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Install libreadline-dev for toolchain builds on ARM hosts
This is required because ARM builds of the toolchain binaries are not
(yet) present in s3://native-toolchain, so ARM builds have to build the
toolchain locally, before being able to build Impala.
The toolchain's Python build failed before this patch, because it missed
the libreadline-dev package, which is needed for Python's readline support.
This patch adds it and its libncurses dependency.
Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
---
M bin/bootstrap_system.sh
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/19835/2
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19835/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:
http://gerrit.cloudera.org:8080/#/c/19835/1/bin/bootstrap_system.sh@229
PS1, Line 229: texinfo bison autoconf automake libtool libz-dev libncurses-dev libncurses5-dev \
line too long (91 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 15:15:27 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Install libreadline-dev for toolchain builds on ARM hosts
This is required because ARM builds of the toolchain binaries are not
(yet) present in s3://native-toolchain, so ARM builds have to build the
toolchain locally, before being able to build Impala.
The toolchain's Python build failed before this patch, because it missed
the libreadline-dev package, which is needed for Python's readline support.
This patch adds it and its libncurses dependency.
Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Reviewed-on: http://gerrit.cloudera.org:8080/19835
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
---
M bin/bootstrap_system.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Verified
Michael Smith: Looks good to me, but someone else must approve
Joe McDonnell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 4
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 May 2023 17:08:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 2:
ARM build reference: https://jenkins.impala.io/job/ubuntu-20.04-from-scratch-ARM/16/
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 20:23:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12916/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 16:31:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 May 2023 17:01:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 1: Code-Review+1
Seems reasonable.
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 15:33:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19835/1/bin/bootstrap_system.sh
File bin/bootstrap_system.sh:
http://gerrit.cloudera.org:8080/#/c/19835/1/bin/bootstrap_system.sh@229
PS1, Line 229: texinfo bison autoconf automake libtool libz-dev libncurses-dev \
> line too long (91 > 90)
Done
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 16:11:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9282/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 May 2023 11:44:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12915/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 1
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 15:35:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 2:
With this change the ubuntu-20.04-from-scratch-ARM build can now build Python successfully, and proceeds until it break on the Kudu build.
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 2
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 May 2023 20:23:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Install libreadline-dev for toolchain builds on ARM hosts
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19835 )
Change subject: Install libreadline-dev for toolchain builds on ARM hosts
......................................................................
Patch Set 3: Code-Review+2
The job got to the next failure, which is related to IMPALA-12100. Let's go ahead.
--
To view, visit http://gerrit.cloudera.org:8080/19835
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf6193027d691d3ded727cb59424c5dc9963ea9
Gerrit-Change-Number: 19835
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 May 2023 17:09:09 +0000
Gerrit-HasComments: No