Re: Patch vote

["Roy T. Fielding" <fi...@kiwi.ICS.UCI.EDU>]

In message <19...@shado.jaguNET.com>, Jim Jagielski writes:
>Comments or votes:
>Index: apache/src/http_main.c
>===================================================================
>RCS file: /export/home/cvs/apache/src/http_main.c,v
>retrieving revision 1.128
>diff -c -r1.128 http_main.c
>*** http_main.c	1997/03/11 06:04:39	1.128
>--- http_main.c	1997/03/15 17:25:46
>***************
>*** 991,998 ****
>      int res = 0;
>  
>      for (i = 0; i < HARD_SERVER_LIMIT; ++i)
>! 	if (scoreboard_image->servers[i].status == SERVER_READY
>! 	  || scoreboard_image->servers[i].status == SERVER_STARTING)
>  	    ++res;
>  
>      return res;
>--- 991,997 ----
>      int res = 0;
>  
>      for (i = 0; i < HARD_SERVER_LIMIT; ++i)
>! 	if (scoreboard_image->servers[i].status == SERVER_READY)
>  	    ++res;

+1

>      return res;
>***************
>*** 1257,1262 ****
>--- 1256,1262 ----
>  
>  void just_die()			/* SIGHUP to child process??? */
>  {
>+     log_error("httpd: child just dieing", server_conf);
>      exit (0);
>  }

+0.  What is the point in logging a meaningless message?  It should
either be made meaningful or not logged.

>***************
>*** 1654,1659 ****
>--- 1654,1660 ----
>  	    || (max_requests_per_child > 0
>  	        && ++requests_this_child >= max_requests_per_child))
>  	{
>+ 	    log_error("httpd: adjusting max-idle",server_conf);
>  	    exit(0);
>  	}

-1.  That is not an error and we don't have a verbose logging option.

.....Roy