You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/13 10:18:20 UTC
[GitHub] [arrow-rs] HaoYang670 opened a new issue, #2720: Don't check the `DivideByZero` error for float modulus
HaoYang670 opened a new issue, #2720:
URL: https://github.com/apache/arrow-rs/issues/2720
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
<!--
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and *why* for this feature, in addition to the *what*)
-->
Currently, we check the `DivideByZero` error for all primitive types in `modulus`: https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/arithmetic.rs#L1098
We should remove this checking for float type because `%0.0` is a legal operation: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=3a34dc3a346d8c3adc845a646d7e9642
**Describe the solution you'd like**
Remove the `DivideByZero` checking for float type and add tests
**Describe alternatives you've considered**
We could not do this but should comment the reason in the docs.
**Additional context**
<!--
Add any other context or screenshots about the feature request here.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on issue #2720: Don't check the `DivideByZero` error for float modulus
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on issue #2720:
URL: https://github.com/apache/arrow-rs/issues/2720#issuecomment-1246292993
Close this issue as we should follow the c++ impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 closed issue #2720: Don't check the `DivideByZero` error for float modulus
Posted by GitBox <gi...@apache.org>.
HaoYang670 closed issue #2720: Don't check the `DivideByZero` error for float modulus
URL: https://github.com/apache/arrow-rs/issues/2720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org