You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Kyle Winkelman (JIRA)" <ji...@apache.org> on 2019/03/15 12:42:00 UTC

[jira] [Resolved] (BEAM-6546) MetricsContainerStepMap equals() method not implemented properly

     [ https://issues.apache.org/jira/browse/BEAM-6546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kyle Winkelman resolved BEAM-6546.
----------------------------------
       Resolution: Resolved
         Assignee: Kyle Winkelman
    Fix Version/s: 2.12.0

> MetricsContainerStepMap equals() method not implemented properly
> ----------------------------------------------------------------
>
>                 Key: BEAM-6546
>                 URL: https://issues.apache.org/jira/browse/BEAM-6546
>             Project: Beam
>          Issue Type: New Feature
>          Components: java-fn-execution
>            Reporter: Alex Amato
>            Assignee: Kyle Winkelman
>            Priority: Major
>             Fix For: 2.12.0
>
>
> This calls equals on the underlying collection of containers it uses, however the containers do not implement equals.
>  
>  
> Open question. It will also be an expensive operation to call equals. Is it necessary to compare MetricContainerStepMaps for equality? Perhaps for unit tests, but is it necessary for production code?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)