You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2025/03/05 13:11:39 UTC
(superset) 15/18: fix(plugin-chart-echarts): remove erroneous upper bound value (#32473)
This is an automated email from the ASF dual-hosted git repository.
michaelsmolina pushed a commit to branch 5.0
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 2199c73b89d3bf7d541d38fc7c6afaf98a1ff9ad
Author: Ville Brofeldt <33...@users.noreply.github.com>
AuthorDate: Sat Mar 1 22:07:12 2025 -0800
fix(plugin-chart-echarts): remove erroneous upper bound value (#32473)
(cherry picked from commit 5766c36372f221d1f4ee93d355a3e4c677f47c19)
---
.../plugin-chart-echarts/src/Timeseries/transformers.ts | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
index cadf647484..0abefc95e3 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
+++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts
@@ -226,7 +226,7 @@ export function transformSeries(
stackId = forecastSeries.name;
} else if (stack && isObservation) {
// the suffix of the observation series is '' (falsy), which disables
- // stacking. Therefore we need to set something that is truthy.
+ // stacking. Therefore, we need to set something that is truthy.
stackId = getTimeCompareStackId('obs', timeCompare, name);
} else if (stack && isTrend) {
stackId = getTimeCompareStackId(forecastSeries.type, timeCompare, name);
@@ -322,6 +322,15 @@ export function transformSeries(
show: !!showValue,
position: isHorizontal ? 'right' : 'top',
formatter: (params: any) => {
+ // don't show confidence band value labels, as they're already visible on the tooltip
+ if (
+ [
+ ForecastSeriesEnum.ForecastUpper,
+ ForecastSeriesEnum.ForecastLower,
+ ].includes(forecastSeries.type)
+ ) {
+ return '';
+ }
const { value, dataIndex, seriesIndex, seriesName } = params;
const numericValue = isHorizontal ? value[0] : value[1];
const isSelectedLegend = !legendState || legendState[seriesName];