You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/13 02:15:50 UTC
[GitHub] [arrow] js8544 opened a new pull request, #14394: ARROW-18019: [C++][Gandiva] Improve Projector evaluation performance
js8544 opened a new pull request, #14394:
URL: https://github.com/apache/arrow/pull/14394
Some dynamic_casts are not necessary because the safety is checked already.
RecordBatch's column(int i) function involves atomic operation and column_data(int i) doesn't. So we prefer to use column_data() instead if column()->data().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] js8544 commented on pull request #14394: ARROW-18019: [C++][Gandiva] Improve Projector evaluation performance
Posted by GitBox <gi...@apache.org>.
js8544 commented on PR #14394:
URL: https://github.com/apache/arrow/pull/14394#issuecomment-1276995284
CI failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #14394: ARROW-18019: [C++][Gandiva] Improve Projector evaluation performance
Posted by GitBox <gi...@apache.org>.
kou merged PR #14394:
URL: https://github.com/apache/arrow/pull/14394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14394: ARROW-18019: [C++][Gandiva] Improve Projector evaluation performance
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14394:
URL: https://github.com/apache/arrow/pull/14394#issuecomment-1291082939
Benchmark runs are scheduled for baseline = 48b48289bf279f4fce073735ab5634e3c6174027 and contender = 63e1756778c8c7f0cfcd3cfca6774cd30ffc6c9d. 63e1756778c8c7f0cfcd3cfca6774cd30ffc6c9d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d7d2248a13204ad985315a47e047a8ef...6ff47c3c7a4841d7b7ba53759a4fe45a/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/974254094fea4d76977373931b2ef0ef...2baf98083e264f4f99c0f3f1a2aebb46/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7afad87d804a438e97f5e7a691bd60b5...1324c1c4e8a04d19b4100225c40709c5/)
[Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/6a86096554984eb6b223f543918d616f...2d917fe076f4426ab7c4583fc7a39b43/)
Buildkite builds:
[Finished] [`63e17567` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1727)
[Failed] [`63e17567` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1746)
[Finished] [`63e17567` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1732)
[Failed] [`63e17567` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1741)
[Finished] [`48b48289` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1726)
[Failed] [`48b48289` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1745)
[Finished] [`48b48289` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1728)
[Failed] [`48b48289` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1740)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14394: ARROW-18019: [C++][Gandiva] Improve Projector evaluation performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14394:
URL: https://github.com/apache/arrow/pull/14394#issuecomment-1276954954
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14394: ARROW-18019: [C++][Gandiva] Improve Projector evaluation performance
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14394:
URL: https://github.com/apache/arrow/pull/14394#issuecomment-1276954940
https://issues.apache.org/jira/browse/ARROW-18019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14394: ARROW-18019: [C++][Gandiva] Improve Projector evaluation performance
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14394:
URL: https://github.com/apache/arrow/pull/14394#issuecomment-1291083191
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/974254094fea4d76977373931b2ef0ef...2baf98083e264f4f99c0f3f1a2aebb46/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7afad87d804a438e97f5e7a691bd60b5...1324c1c4e8a04d19b4100225c40709c5/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org