[jira] [Commented] (FALCON-397) DistCp uses JobSubmissionFiles API which is incompatible between hadoop versions

["Suresh Srinivas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FALCON-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963924#comment-13963924 ] 

Suresh Srinivas commented on FALCON-397:
----------------------------------------

Comments:
# There are many white space and changes that splits a long line. Eliminating that would keep the patch small and to the point.
# getStagingPath() method implementation:
#* Method only throws RunTimeException. So having a generic Exception as in the throw clause in declaration is not necessary. Also when throwing exceptions from a method, always declaring more specific exception is better.
#* Only catch NoSuchMethodException and ClassNotFoundException in try blocks while doing reflection instead of catching more generic class Exception.
#* Log an info level log to indicate hadoop-2 version of the method is not found and trying hadoop-1 version of the method would be good for debugging. 


> DistCp uses JobSubmissionFiles API which is incompatible between hadoop versions
> --------------------------------------------------------------------------------
>
>                 Key: FALCON-397
>                 URL: https://issues.apache.org/jira/browse/FALCON-397
>             Project: Falcon
>          Issue Type: Bug
>          Components: replication
>    Affects Versions: 0.5
>            Reporter: Venkatesh Seetharam
>            Assignee: Venkatesh Seetharam
>              Labels: distcp
>             Fix For: 0.5
>
>         Attachments: FALCON-397.patch
>
>
> JobSubmissionFiles.getStagingDir has changed in hadoop-2. This patch addresses this issue by using reflection.



--
This message was sent by Atlassian JIRA
(v6.2#6252)