[GitHub] [hive] abstractdog commented on a diff in pull request #4009: HIVE-23935. Fetching primaryKey through beeline fails with NPE.

["abstractdog (via GitHub)" <gi...@apache.org>]

abstractdog commented on code in PR #4009:
URL: https://github.com/apache/hive/pull/4009#discussion_r1094387999


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:
##########
@@ -12025,7 +12025,9 @@ private List<SQLPrimaryKey> getPrimaryKeysInternal(final String catName,
                                                      final String db_name_input,
                                                      final String tbl_name_input)
   throws MetaException, NoSuchObjectException {
-    final String db_name = normalizeIdentifier(db_name_input);
+    final String db_name = StringUtils.isNotBlank(db_name_input) ?

Review Comment:
   1. can you please fix db_name_input and tbl_name_input naming nightmare as you're touching this part?
   2. what about fixing this in normalizeIdentifier instead?
   ```
   return identifier == null ? null : identifier.trim().toLowerCase();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org