You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/02/25 07:50:48 UTC
[GitHub] [httpcomponents-core] arturobernalg opened a new pull request #267: HTTPCORE-670 - Add new headers
arturobernalg opened a new pull request #267:
URL: https://github.com/apache/httpcomponents-core/pull/267
Add new header
Set-Cookie2 --> https://tools.ietf.org/html/rfc2965
Set-Cookie --> https://tools.ietf.org/html/rfc2109#section-4.2.2
Link --> href="https://tools.ietf.org/html/rfc5988
Cookie --> https://tools.ietf.org/html/rfc2109
Content-Disposition --> https://tools.ietf.org/html/rfc6266
Access-Control-Request-Method --> https://www.w3.org/TR/cors
Access-Control-Request-Headers --> https://www.w3.org/TR/cors
Access-Control-Max-Age --> https://www.w3.org/TR/cors
Access-Control-Expose-Headers --> https://www.w3.org/TR/cors
Access-Control-Allow-Origin --> https://www.w3.org/TR/cors
Access-Control-Allow-Methods --> https://www.w3.org/TR/cors
Access-Control-Allow-Credentials -->https://www.w3.org/TR/cors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] arturobernalg commented on a change in pull request #267: HTTPCORE-670 - Add new headers
Posted by GitBox <gi...@apache.org>.
arturobernalg commented on a change in pull request #267:
URL: https://github.com/apache/httpcomponents-core/pull/267#discussion_r582733294
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -130,6 +188,17 @@ private HttpHeaders() {
public static final String STATUS_URI = "Status-URI";
+ /**
+ * The HTTP {@code Set-Cookie} header field name.
+ * @see <a href="https://tools.ietf.org/html/rfc2109#section-4.2.2">Section 4.2.2 of RFC 2109</a>
+ */
+ public static final String SET_COOKIE = "Set-Cookie";
+ /**
+ * The HTTP {@code Set-Cookie2} header field name.
+ * @see <a href="https://tools.ietf.org/html/rfc2965">RFC 2965</a>
+ */
+ public static final String SET_COOKIE2 = "Set-Cookie2";
Review comment:
Agree, changed
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -130,6 +188,17 @@ private HttpHeaders() {
public static final String STATUS_URI = "Status-URI";
+ /**
+ * The HTTP {@code Set-Cookie} header field name.
+ * @see <a href="https://tools.ietf.org/html/rfc2109#section-4.2.2">Section 4.2.2 of RFC 2109</a>
Review comment:
Agree, changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c merged pull request #267: HTTPCORE-670 - Add new headers
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #267:
URL: https://github.com/apache/httpcomponents-core/pull/267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-core] ok2c commented on a change in pull request #267: HTTPCORE-670 - Add new headers
Posted by GitBox <gi...@apache.org>.
ok2c commented on a change in pull request #267:
URL: https://github.com/apache/httpcomponents-core/pull/267#discussion_r582687442
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -130,6 +188,17 @@ private HttpHeaders() {
public static final String STATUS_URI = "Status-URI";
+ /**
+ * The HTTP {@code Set-Cookie} header field name.
+ * @see <a href="https://tools.ietf.org/html/rfc2109#section-4.2.2">Section 4.2.2 of RFC 2109</a>
Review comment:
@arturobernalg I am not sure about references to RFCs in the source code. For instance, HttpClient conforms to rfc6265 and not rfc2109. I would not want to scan the source code for RFC references every time protocol level gets upgraded.
##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/HttpHeaders.java
##########
@@ -130,6 +188,17 @@ private HttpHeaders() {
public static final String STATUS_URI = "Status-URI";
+ /**
+ * The HTTP {@code Set-Cookie} header field name.
+ * @see <a href="https://tools.ietf.org/html/rfc2109#section-4.2.2">Section 4.2.2 of RFC 2109</a>
+ */
+ public static final String SET_COOKIE = "Set-Cookie";
+ /**
+ * The HTTP {@code Set-Cookie2} header field name.
+ * @see <a href="https://tools.ietf.org/html/rfc2965">RFC 2965</a>
+ */
+ public static final String SET_COOKIE2 = "Set-Cookie2";
Review comment:
@arturobernalg `Set-Cookie2` is considered obsolete and should not be used. I would not include it,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org