You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Benjamin Hindman (JIRA)" <ji...@apache.org> on 2014/01/07 17:49:50 UTC
[jira] [Commented] (MESOS-895) Removal of libev patch
[ https://issues.apache.org/jira/browse/MESOS-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864379#comment-13864379 ]
Benjamin Hindman commented on MESOS-895:
----------------------------------------
What does he mean by a "wrapper"? Also, what if libev is built for the platform but wasn't built with CLAGS=-DEV_CHILD_ENABLE=0?
> Removal of libev patch
> ----------------------
>
> Key: MESOS-895
> URL: https://issues.apache.org/jira/browse/MESOS-895
> Project: Mesos
> Issue Type: Bug
> Components: build
> Affects Versions: 0.17.0
> Reporter: Timothy St. Clair
>
> The libev patch can easily be removed and update the configuration flags and possibly the accompanying code prior to include.
> For configure pass in:
> CFLAGS=-DEV_CHILD_ENABLE=0
> For inclusion:
> #define EV_CHILD_ENABLE 0
> include <ev.h>
> excerpt from maintainer:
> <schmorp> that patch is unnecessary
> <tstclair> schmorp, so if they wanted to just set EV_CHILD_ENABLE=0 they could just pass CFLAGS=-DEV_CHILD_ENABLE=0 through.
> <schmorp> tstclair: yes, or use a wrapper
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)