You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2026/05/23 20:10:41 UTC
[PR] Fix artifact relocation support [maven-dependency-plugin]
slawekjaranowski opened a new pull request, #1633:
URL: https://github.com/apache/maven-dependency-plugin/pull/1633
- Update ITs for `copy`, `unpack`, and relocation use cases.
- Simplify and align artifact verification in integration tests.
---
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in other changes.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [ ] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix artifact relocation support [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #1633:
URL: https://github.com/apache/maven-dependency-plugin/pull/1633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix artifact relocation support [maven-dependency-plugin]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #1633:
URL: https://github.com/apache/maven-dependency-plugin/pull/1633#issuecomment-4529264437
ok, I did not see linked issue: I'm definitively lost with GH issues...
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix artifact relocation support [maven-dependency-plugin]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on PR #1633:
URL: https://github.com/apache/maven-dependency-plugin/pull/1633#issuecomment-4529022929
if this is a fix, it means something was not working as expected?
what was expected that actual was not ok?
it's hard to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix artifact relocation support [maven-dependency-plugin]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #1633:
URL: https://github.com/apache/maven-dependency-plugin/pull/1633#issuecomment-4529061746
@hboutemy it fix linked issue
reproduce:
add `src/it/mrm/repository/ResourceArtifact-relocation-1.0.pom` artifact with relocation information
next it is used in `src/it/projects/copy-relocation/pom.xml` and in verification `src/it/projects/copy-relocation/verify.groovy` we see that artifact `ResourceArtifact-1.0.jar` was used - so information about relocation was consider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org