You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by rnewson <gi...@git.apache.org> on 2015/09/11 18:23:03 UTC
[GitHub] couchdb-chttpd pull request: Allow filtering of active tasks by pr...
GitHub user rnewson opened a pull request:
https://github.com/apache/couchdb-chttpd/pull/72
Allow filtering of active tasks by property
COUCHDB-2807
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-chttpd 2807-filtered-tasks
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-chttpd/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit b4e280db003a6f71dca169a9601f231563843d36
Author: Robert Newson <rn...@apache.org>
Date: 2015-09-11T16:22:42Z
Allow filtering of active tasks by property
COUCHDB-2807
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Allow filtering of active tasks by pr...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/72#issuecomment-140342958
I don't like it after all
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Allow filtering of active tasks by pr...
Posted by rnewson <gi...@git.apache.org>.
Github user rnewson closed the pull request at:
https://github.com/apache/couchdb-chttpd/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Allow filtering of active tasks by pr...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/72#issuecomment-139792840
I think API is incorrect since you use HTTP resources as filters, not to define some new thing. I think filtering should be done with query parameters, which will allow to filter by multiple properties, like "show me all replications for node1 which run by user foo against target bar".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-chttpd pull request: Allow filtering of active tasks by pr...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-chttpd/pull/72#issuecomment-139793781
Also, it seems not all properties could be used for filtering:
```
$ http --json http://localhost:15984/_active_tasks/continuous/true
[
{
"changes_pending": 1692895,
"checkpoint_interval": 5000,
"checkpointed_source_seq": 57182,
"continuous": true,
"doc_id": null,
"doc_write_failures": 0,
"docs_read": 6118,
"docs_written": 6118,
"missing_revisions_found": 6118,
"node": "node1@127.0.0.1",
"pid": "<0.1641.0>",
"replication_id": "a2d6fd6b275527acdf245abca30d7597+continuous+create_target",
"revisions_checked": 6118,
"source": "http://localhost:5984/hashes/",
"source_seq": 57182,
"started_on": 1442074677,
"target": "http://127.0.0.1:15984/hashes/",
"through_seq": 57182,
"type": "replication",
"updated_on": 1442075004,
"user": null
}
]
$ http --json http://localhost:15984/_active_tasks/node/node1%40127.0.0.1
[]
$ http --json http --json http://localhost:15984/_active_tasks/pid/%3C0.1641.0%3E
[]
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---