You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@quickstep.apache.org by johnchronis <gi...@git.apache.org> on 2018/10/08 23:23:15 UTC
[GitHub] incubator-quickstep pull request #362: Add virtual destructors where needed ...
GitHub user johnchronis opened a pull request:
https://github.com/apache/incubator-quickstep/pull/362
Add virtual destructors where needed to remove compile time errors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnchronis/incubator-quickstep master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit 57af85b14df439008ad76f5dbea1a8bd86f93cf4
Author: johnchronis <jo...@...>
Date: 2018-10-08T23:01:27Z
Add virtual destructors where they are needed to remove compilations errors.
commit 99158dde956d2f45196cbf6537c1049cf9396f1c
Author: johnchronis <jo...@...>
Date: 2018-10-08T23:10:08Z
Fix order of virtual destructors.
commit 33be175085f177269cc431343ff87df575737cd0
Author: Yannis Chronis <jo...@...>
Date: 2018-10-08T23:14:09Z
Fix order of virtual destructors.
commit 286cde85b0861245d304198b0cbd18f0f2363de3
Author: Yannis Chronis <jo...@...>
Date: 2018-10-08T23:18:18Z
mend
commit 06d8d9f7939015f608af260eaee0764ea9cb7f8b
Author: Yannis Chronis <jo...@...>
Date: 2018-10-08T23:18:18Z
Fix order of virtual destructors.
commit 4a5a9a02c820d3779f8aec9b723a95e96348eddc
Author: Yannis Chronis <jo...@...>
Date: 2018-10-08T23:21:58Z
Merge branch 'master' of https://github.com/johnchronis/incubator-quickstep
----
---
[GitHub] incubator-quickstep issue #362: Add virtual destructors where needed to remo...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/362
For completeness, please add `override` for the destructors of derived classes of `GeneratorFunctionHandle`, `LIPFilter`, and `BaseClass`. Thanks!
---
[GitHub] incubator-quickstep pull request #362: Add virtual destructors where needed ...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/362#discussion_r224538733
--- Diff: utility/lip_filter/SingleIdentityHashFilter.hpp ---
@@ -66,6 +66,8 @@ class SingleIdentityHashFilter : public LIPFilter {
DCHECK_GE(filter_cardinality, 1u);
}
+ ~SingleIdentityHashFilter() {};
--- End diff --
Add `override`.
---
[GitHub] incubator-quickstep pull request #362: Add virtual destructors where needed ...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/362#discussion_r224539118
--- Diff: third_party/src/tmb/tests/message_bus_unittest_common.h ---
@@ -205,7 +207,7 @@ class ConnectorThread : public Thread {
}
protected:
- void Run() {
+ void Run() override {
--- End diff --
Add `override` destructors in this file.
---
[GitHub] incubator-quickstep pull request #362: Add virtual destructors where needed ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-quickstep/pull/362
---
[GitHub] incubator-quickstep issue #362: Add virtual destructors where needed to remo...
Posted by zuyu <gi...@git.apache.org>.
Github user zuyu commented on the issue:
https://github.com/apache/incubator-quickstep/pull/362
LGTM. Squash the commits and once the checks pass, I can merge.
---