[GitHub] [incubator-pinot] npawar commented on a change in pull request #6503: Validation to prevent derived column using derived column

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #6503:
URL: https://github.com/apache/incubator-pinot/pull/6503#discussion_r566542101



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##########
@@ -278,11 +279,42 @@ public static void validateIngestionConfig(TableConfig tableConfig, @Nullable Sc
                 "Arguments of a transform function '" + arguments + "' cannot contain the destination column '"
                     + columnName + "'");
           }
+          columnToFunction.put(columnName, expressionEvaluator);
+        }
+        Map<String, Integer> chainDepth = new HashMap<>();
+        for (String column : columnToFunction.keySet()) {
+          Preconditions.checkState(transformFunctionChainDepth(column, columnToFunction, chainDepth) <= 2,

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org