You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/03/11 15:22:59 UTC

Re: [jclouds-labs-google] [JCLOUDS-442] reduces the firewalls created by createNodesInGroup (#20)

>      * @see org.jclouds.googlecomputeengine.features.FirewallApi#patch(String, org.jclouds.googlecomputeengine.options.FirewallOptions)
>      */
> -   private void getOrCreateFirewalls(GoogleComputeEngineTemplateOptions templateOptions, Network network,
> -                                     FirewallTagNamingConvention naming) {
> -
> +   private void getAndPatchOrCreateFirewalls(GoogleComputeEngineTemplateOptions templateOptions, Network network,

Could we replace "Patch" with "Update" or "Modify" here? I always associate "Patch" with some kind of temporary fix ;-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20/files#r10474592