You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/02 17:53:21 UTC
[kudu-CR] [KUDU-3218] Ignore transaction clone symbols comming from std
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16810
Change subject: [KUDU-3218] Ignore transaction clone symbols comming from std
......................................................................
[KUDU-3218] Ignore transaction clone symbols comming from std
To unbreak Centos 7 test runs this patch ignores the transaction clone
symbols comming from `std::` in the client_symbol-test.
A TODO remains to investigate further.
Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
---
M src/kudu/client/client_symbol-test.sh
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/16810/1
--
To view, visit http://gerrit.cloudera.org:8080/16810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Gerrit-Change-Number: 16810
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [KUDU-3218] Ignore transaction clone symbols comming from std
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16810
to look at the new patch set (#2).
Change subject: [KUDU-3218] Ignore transaction clone symbols comming from std
......................................................................
[KUDU-3218] Ignore transaction clone symbols comming from std
To unbreak Centos 7 test runs this patch ignores the transaction clone
symbols comming from `std::` in the client_symbol-test.
A TODO remains to investigate further.
Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
---
M src/kudu/client/client_symbol-test.sh
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/16810/2
--
To view, visit http://gerrit.cloudera.org:8080/16810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Gerrit-Change-Number: 16810
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-3218] Ignore transaction clone symbols comming from std
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16810 )
Change subject: [KUDU-3218] Ignore transaction clone symbols comming from std
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/16810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Gerrit-Change-Number: 16810
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 18:57:29 +0000
Gerrit-HasComments: No
[kudu-CR] [KUDU-3218] Ignore transaction clone symbols coming from std
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16810 )
Change subject: [KUDU-3218] Ignore transaction clone symbols coming from std
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16810/1/src/kudu/client/client_symbol-test.sh
File src/kudu/client/client_symbol-test.sh:
http://gerrit.cloudera.org:8080/#/c/16810/1/src/kudu/client/client_symbol-test.sh@79
PS1, Line 79: transaction clone for std::
> Yeah, I am also seeing those. I was still testing the patch and I also see
I see, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/16810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Gerrit-Change-Number: 16810
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 21:55:08 +0000
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3218] Ignore transaction clone symbols comming from std
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16810 )
Change subject: [KUDU-3218] Ignore transaction clone symbols comming from std
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16810/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16810/1//COMMIT_MSG@7
PS1, Line 7: comming
nit: coming
http://gerrit.cloudera.org:8080/#/c/16810/1/src/kudu/client/client_symbol-test.sh
File src/kudu/client/client_symbol-test.sh:
http://gerrit.cloudera.org:8080/#/c/16810/1/src/kudu/client/client_symbol-test.sh@77
PS1, Line 77: comming
nit: coming
--
To view, visit http://gerrit.cloudera.org:8080/16810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Gerrit-Change-Number: 16810
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:45:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3218] Ignore transaction clone symbols coming from std
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16810 )
Change subject: [KUDU-3218] Ignore transaction clone symbols coming from std
......................................................................
[KUDU-3218] Ignore transaction clone symbols coming from std
To unbreak Centos 7 test runs this patch ignores the transaction clone
symbols coming from `std::` in the client_symbol-test.
A TODO remains to investigate further.
Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Reviewed-on: http://gerrit.cloudera.org:8080/16810
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/client/client_symbol-test.sh
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Gerrit-Change-Number: 16810
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-3218] Ignore transaction clone symbols coming from std
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16810 )
Change subject: [KUDU-3218] Ignore transaction clone symbols coming from std
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/16810/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16810/1//COMMIT_MSG@7
PS1, Line 7: comming
> nit: coming
Done
http://gerrit.cloudera.org:8080/#/c/16810/1/src/kudu/client/client_symbol-test.sh
File src/kudu/client/client_symbol-test.sh:
http://gerrit.cloudera.org:8080/#/c/16810/1/src/kudu/client/client_symbol-test.sh@77
PS1, Line 77: comming
> nit: coming
Done
http://gerrit.cloudera.org:8080/#/c/16810/1/src/kudu/client/client_symbol-test.sh@79
PS1, Line 79: transaction clone for std::
> Just curious: are these the only extra symbols appeared or there is somethi
Yeah, I am also seeing those. I was still testing the patch and I also see the delete symbols as well (which is expected based on the transactional memory docs). I included them in the filter.
--
To view, visit http://gerrit.cloudera.org:8080/16810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Gerrit-Change-Number: 16810
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:58:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [KUDU-3218] Ignore transaction clone symbols coming from std
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16810
to look at the new patch set (#3).
Change subject: [KUDU-3218] Ignore transaction clone symbols coming from std
......................................................................
[KUDU-3218] Ignore transaction clone symbols coming from std
To unbreak Centos 7 test runs this patch ignores the transaction clone
symbols coming from `std::` in the client_symbol-test.
A TODO remains to investigate further.
Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
---
M src/kudu/client/client_symbol-test.sh
1 file changed, 9 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/16810/3
--
To view, visit http://gerrit.cloudera.org:8080/16810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Gerrit-Change-Number: 16810
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [KUDU-3218] Ignore transaction clone symbols comming from std
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16810 )
Change subject: [KUDU-3218] Ignore transaction clone symbols comming from std
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16810/1/src/kudu/client/client_symbol-test.sh
File src/kudu/client/client_symbol-test.sh:
http://gerrit.cloudera.org:8080/#/c/16810/1/src/kudu/client/client_symbol-test.sh@79
PS1, Line 79: transaction clone for std::
Just curious: are these the only extra symbols appeared or there is something else? E.g., on CentOS 6 with devtoolset-8, in addition to transaction clone I also saw
Found bad symbol 'operator delete[](void*, unsigned long)'
Found bad symbol 'operator delete(void*, unsigned long)'
--
To view, visit http://gerrit.cloudera.org:8080/16810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c3b95a87e404ffffff4bff7882020d0b92a585a
Gerrit-Change-Number: 16810
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:54:55 +0000
Gerrit-HasComments: Yes