[jira] [Commented] (BIGTOP-2026) Phoenix build defines HBASE_VERSION in two different places.

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739738#comment-14739738 ] 

Konstantin Boudnik commented on BIGTOP-2026:
--------------------------------------------

Andrew, that looks like a right thing and thanks for testing it! The only thing: with BIGTOP-1494 in place you'll need to refactor bigtop.mk part and make the change in bigtop.bom file, which is the new stack config. It should be all easy to do, but if you need any help - ping me here or on the IRC and I'd be happy to help!

> Phoenix build defines HBASE_VERSION in two different places.
> ------------------------------------------------------------
>
>                 Key: BIGTOP-2026
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2026
>             Project: Bigtop
>          Issue Type: Bug
>          Components: debian, rpm
>    Affects Versions: 1.0.0
>            Reporter: Konstantin Boudnik
>            Assignee: Andrew Purtell
>             Fix For: 1.1.0
>
>         Attachments: BIGTOP-2026.patch
>
>
> {noformat}
> % ack-grep PHOENIX_HBASE_VERSION *
> bigtop.mk
> 282:PHOENIX_HBASE_VERSION=HBase-0.98
> 283:PHOENIX_TARBALL_DST=phoenix-$(PHOENIX_BASE_VERSION)-$(PHOENIX_HBASE_VERSION)-src.tar.gz
> 285:PHOENIX_DOWNLOAD_PATH=/phoenix/phoenix-$(PHOENIX_BASE_VERSION)-$(PHOENIX_HBASE_VERSION)/src/
> bigtop-packages/src/common/phoenix/do-component-build
> 21:PHOENIX_HBASE_VERSION=HBase-0.98
> 32:tar -C build --strip-components=1 -xzf phoenix-assembly/target/phoenix-$PHOENIX_VERSION-${PHOENIX_HBASE_VERSION}.tar.gz
> {noformat}
> The variable is defined twice and can lead to integration problems if it gets changed independently. {{do-component-build}} should use the one from the BOM



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)