[GitHub] [camel-quarkus] ppalaga opened a new pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders

[GitBox <gi...@apache.org>]

ppalaga opened a new pull request #358: Fix #136 @ConfigProperty and @Inject do not work in RouteBuilders
URL: https://github.com/apache/camel-quarkus/pull/358
 
 
   The main idea here is to provide a custom `QuarkusInjector` that first looks up the given type in the Arc container before falling back to direct instantiation. At the same time RoutesBuilders are not instantiated by us, we rather supply the RoutesBuilder class names to Camel main to instantiate them via our `QuarkusInjector`.
   
   Let's discuss whether the above is a good idea.
   
   I see the following possible risks:
   
   1. Slower instantiation and thus slower boot because all types are first looked up in the Arc container. I should perhaps try to measure the difference.
   2. The instantiation of the RoutesBuilders moves from STATIC_INIT to RUNTIME_INIT. Native image boot time may get worse due to this.
   
   Both 1. and 2. could get mitigated for RoutesBuilders that do not contain any injection points by filtering out those and instantiating them as we do now, whereas only RoutesBuilders with injection points would be instantiated as sketched in this proposal. The question is whether the more complex implementation is worth the effort.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services