You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/17 19:23:23 UTC

[GitHub] [hadoop-ozone] errose28 opened a new pull request #1216: HDDS-3976. KeyValueBlockIterator#nextBlock skips valid blocks

errose28 opened a new pull request #1216:
URL: https://github.com/apache/hadoop-ozone/pull/1216


   ## What changes were proposed in this pull request?
   
   1. Fix the bug in KeyValueBlockIterator#nextBlocks that skips keys passing the prefix filter when all prefixed keys do not occur at the end of the key list.
       - New implementation removes indirect recursion in favor of a strictly iterative approach.
   
   2. Remove the unused KeyValueBlockIterator#seekLast method that did not work when the last key in the list failed the filter.
   
   3. Add a more robust unit test that covers the following two cases without depending on the order that the RocksDB RocksIterator returns keys:
       1. The key list contains a key failing the filter followed by a key passing the filter.
       2. The key list contains a key passing the filter followed by a key failing the filter.
   
   4. Minor clarifications in existing unit tests.
       - TestKeyValueBlockIterator#createContainerWithBlocks now uses prefixes that match the names of its parameters.
       - TestKeyValueBlockIterator#createContainerWithBlocks literally creates the number of each block type given in the parameters.
   
   ## What is the link to the Apache JIRA
   
   [HDDS-3976](https://issues.apache.org/jira/browse/HDDS-3976)
   
   ## How was this patch tested?
   
   KeyValueBlockIterator passed the existing unit tests and the newly created unit test.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] hanishakoneru closed pull request #1216: HDDS-3976. KeyValueBlockIterator#nextBlock skips valid blocks

Posted by GitBox <gi...@apache.org>.
hanishakoneru closed pull request #1216:
URL: https://github.com/apache/hadoop-ozone/pull/1216


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org